Fix not-authorized error message.

remoting/webapp/app_remoting/js/app_remoting_activity.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 /**
  * Type definition for the RunApplicationResponse returned by the API.
  * @typedef {{
@@ skipping 120 matching lines @@
           remoting.Application.Mode.APP_REMOTING, host,
           new remoting.CredentialsProvider(
               {fetchThirdPartyToken: fetchThirdPartyToken}));
 
     } else if (response && response.status == 'pending') {
       this.onError(new remoting.Error(
           remoting.Error.Tag.SERVICE_UNAVAILABLE));
     }
   } else {
     console.error('Invalid "runApplication" response from server.');
-    this.onError(remoting.Error.fromHttpStatus(xhrResponse.status));
+    // The orchestrator returns 403 if the user is not whitelisted to run the
+    // app, which gets translated to a generic error message, so pick something
+    // a bit more user-friendly.
+    var error = xhrResponse.status == 403 ?
+        new remoting.Error(remoting.Error.Tag.APP_NOT_AUTHORIZED) :
+        remoting.Error.fromHttpStatus(xhrResponse.status);
+    this.onError(error);

[kelvinp, 2015/04/24 22:14:37]

need to merge with ToT to call onConnectionFailed() instead.

   }
 };
 
 /**
  * @param {remoting.ConnectionInfo} connectionInfo
  */
 remoting.AppRemotingActivity.prototype.onConnected = function(connectionInfo) {
   this.connectedView_ = new remoting.AppConnectedView(
       document.getElementById('client-container'), connectionInfo);
 
@@ skipping 20 matching lines @@
   this.onError(error);
 };
 
 /**
  * @param {!remoting.Error} error The error to be localized and displayed.
  */
 remoting.AppRemotingActivity.prototype.onError = function(error) {
   console.error('Connection failed: ' + error.toString());
   remoting.LoadingWindow.close();
   remoting.MessageWindow.showErrorMessage(
-      chrome.i18n.getMessage(/*i18n-content*/'CONNECTION_FAILED'),
+      remoting.app.getApplicationName(),

[Jamie, 2015/04/24 22:04:52]

See point (b), above.

       chrome.i18n.getMessage(error.getTag()));
   this.cleanup_();
 };
 
 })();