Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1073003005: Fix not-authorized error message. (Closed)

Created:
5 years, 8 months ago by Jamie
Modified:
5 years, 8 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix not-authorized error message. BUG=b/19899195 Committed: https://crrev.com/df3da736caa879bfcd6850811e27a0d36e0b4c4e Cr-Commit-Position: refs/heads/master@{#326935}

Patch Set 1 #

Patch Set 2 : Simpler implementation. #

Total comments: 3

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M remoting/webapp/app_remoting/js/app_remoting.js View 1 chunk +1 line, -1 line 0 comments Download
M remoting/webapp/app_remoting/js/app_remoting_activity.js View 1 2 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jamie
ptal https://codereview.chromium.org/1073003005/diff/20001/remoting/webapp/app_remoting/js/app_remoting.js File remoting/webapp/app_remoting/js/app_remoting.js (left): https://codereview.chromium.org/1073003005/diff/20001/remoting/webapp/app_remoting/js/app_remoting.js#oldcode51 remoting/webapp/app_remoting/js/app_remoting.js:51: chrome.i18n.getMessage(/*i18n-content*/'CONNECTION_FAILED'), Connection failed is the wrong message here ...
5 years, 8 months ago (2015-04-24 22:04:52 UTC) #2
kelvinp
lgtm https://codereview.chromium.org/1073003005/diff/20001/remoting/webapp/app_remoting/js/app_remoting_activity.js File remoting/webapp/app_remoting/js/app_remoting_activity.js (right): https://codereview.chromium.org/1073003005/diff/20001/remoting/webapp/app_remoting/js/app_remoting_activity.js#newcode147 remoting/webapp/app_remoting/js/app_remoting_activity.js:147: this.onError(error); need to merge with ToT to call ...
5 years, 8 months ago (2015-04-24 22:14:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073003005/40001
5 years, 8 months ago (2015-04-24 22:31:28 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-24 23:43:49 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 23:44:41 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/df3da736caa879bfcd6850811e27a0d36e0b4c4e
Cr-Commit-Position: refs/heads/master@{#326935}

Powered by Google App Engine
This is Rietveld 408576698