Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 1072963002: PPC: [turbofan] Add new Float32Abs and Float64Abs operators. (Closed)

Created:
5 years, 8 months ago by michael_dawson
Modified:
5 years, 8 months ago
Reviewers:
MTBrandyberry
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [turbofan] Add new Float32Abs and Float64Abs operators. Port 9af9f1d0262e2dab66c62331a03f6a76504f3866 Original commit message: These operators compute the absolute floating point value of some arbitrary input, and are implemented without any branches (i.e. using vabs on arm, and andps/andpd on x86). R=mbrandy@us.ibm.com BUG= Committed: https://crrev.com/c00de38657643f7c44d70d7217cc4ea0ec92eeeb Cr-Commit-Position: refs/heads/master@{#27727}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/ppc/instruction-codes-ppc.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
michael_dawson
Catching up, next PPC port
5 years, 8 months ago (2015-04-09 21:35:09 UTC) #1
MTBrandyberry
On 2015/04/09 21:35:09, michael_dawson wrote: > Catching up, next PPC port lgtm
5 years, 8 months ago (2015-04-09 21:43:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072963002/1
5 years, 8 months ago (2015-04-09 21:49:09 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 22:29:34 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 22:29:40 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c00de38657643f7c44d70d7217cc4ea0ec92eeeb
Cr-Commit-Position: refs/heads/master@{#27727}

Powered by Google App Engine
This is Rietveld 408576698