Issue 107293013: drive: Stop comparing resource ID against kDriveGrandRootLocalId

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 107293013: drive: Stop comparing resource ID against kDriveGrandRootLocalId (Closed)

Created:
6 years, 11 months ago by hashimoto

Modified:
6 years, 11 months ago

Reviewers:
kinaba

CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Stop comparing resource ID against kDriveGrandRootLocalId Add local_id to DirectoryFetchInfo. After this change, there is no need to set dummy resource ID for the grand root. BUG=324719 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243497

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -28 lines)			Patch
M	chrome/browser/chromeos/drive/change_list_loader.cc	View	7 chunks	+14 lines, -12 lines	0 comments	Download
M	chrome/browser/chromeos/drive/change_list_processor.h	View	2 chunks	+9 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/drive/change_list_processor.cc	View	4 chunks	+7 lines, -11 lines	0 comments	Download
M	chrome/browser/chromeos/drive/change_list_processor_unittest.cc	View	2 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/107293013/1

6 years, 11 months ago (2014-01-07 10:38:37 UTC) #3

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=208441

6 years, 11 months ago (2014-01-07 13:22:08 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/107293013/1

6 years, 11 months ago (2014-01-08 02:00:59 UTC) #5

Message was sent while issue was closed.

Change committed as 243497

Expand Messages | Collapse Messages