Issue 107293012: Refactor device description out of PrivetDeviceLister

Issue 107293012: Refactor device description out of PrivetDeviceLister (Closed)

Created:
6 years, 11 months ago by Noam Samuel

Modified:
6 years, 11 months ago

Reviewers:
Vitaly Buka (NO REVIEWS)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Refactor device description out of PrivetDeviceLister This should enable the creation of a separate PrivetDeviceResolver class, which should be useful. BUG=332182 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244028

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+123 lines, -83 lines)			Patch
A	chrome/browser/local_discovery/device_description.h	View	1	1 chunk	+51 lines, -0 lines	0 comments	Download
A	chrome/browser/local_discovery/device_description.cc	View	1	1 chunk	+68 lines, -0 lines	0 comments	Download
M	chrome/browser/local_discovery/privet_device_lister.h	View		2 chunks	+1 line, -29 lines	0 comments	Download
M	chrome/browser/local_discovery/privet_device_lister_impl.cc	View		2 chunks	+1 line, -54 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Vitaly Buka (NO REVIEWS)

lgtm https://codereview.chromium.org/107293012/diff/1/chrome/browser/local_discovery/device_description.h File chrome/browser/local_discovery/device_description.h (right): https://codereview.chromium.org/107293012/diff/1/chrome/browser/local_discovery/device_description.h#newcode1 chrome/browser/local_discovery/device_description.h:1: // Copyright (c) 2014 The Chromium Authors. All ...

6 years, 11 months ago (2014-01-07 21:16:22 UTC) #2

Noam Samuel

https://codereview.chromium.org/107293012/diff/1/chrome/browser/local_discovery/device_description.h File chrome/browser/local_discovery/device_description.h (right): https://codereview.chromium.org/107293012/diff/1/chrome/browser/local_discovery/device_description.h#newcode1 chrome/browser/local_discovery/device_description.h:1: // Copyright (c) 2014 The Chromium Authors. All rights ...

6 years, 11 months ago (2014-01-09 21:30:33 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/107293012/70001

6 years, 11 months ago (2014-01-09 21:34:45 UTC) #5

Message was sent while issue was closed.

Change committed as 244028

Expand Messages | Collapse Messages