Fixes bug in far branches on MIPS.

runtime/vm/assembler_mips_test.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_MIPS)
 
 #include "vm/assembler.h"
 #include "vm/os.h"
 #include "vm/unit_test.h"
@@ skipping 675 matching lines @@
   __ jr(RA);
 }
 
 
 ASSEMBLER_TEST_RUN(Beq_backward, test) {
   typedef int (*SimpleCode)();
   EXPECT_EQ(2, EXECUTE_TEST_CODE_INT32(SimpleCode, test->entry()));
 }
 
 
+ASSEMBLER_TEST_GENERATE(Beq_backward_far, assembler) {
+  Label l;
+
+  __ set_use_far_branches(true);
+
+  __ LoadImmediate(T1, 0);
+  __ LoadImmediate(T2, 1);
+  __ Bind(&l);
+  __ addiu(T1, T1, Immediate(1));
+  __ beq(T1, T2, &l);
+  __ ori(V0, T1, Immediate(0));
+  __ jr(RA);
+}
+
+
+ASSEMBLER_TEST_RUN(Beq_backward_far, test) {
+  typedef int (*SimpleCode)();
+  EXPECT_EQ(2, EXECUTE_TEST_CODE_INT32(SimpleCode, test->entry()));
+}
+
+
 ASSEMBLER_TEST_GENERATE(Beq_backward_delay, assembler) {
   Label l;
 
   __ LoadImmediate(T1, 0);
   __ LoadImmediate(T2, 1);
   __ Bind(&l);
   __ addiu(T1, T1, Immediate(1));
   __ beq(T1, T2, &l);
   __ delay_slot()->addiu(T1, T1, Immediate(1));
   __ ori(V0, T1, Immediate(0));
@@ skipping 20 matching lines @@
   __ jr(RA);
 }
 
 
 ASSEMBLER_TEST_RUN(Beq_forward_taken, test) {
   typedef int (*SimpleCode)();
   EXPECT_EQ(42, EXECUTE_TEST_CODE_INT32(SimpleCode, test->entry()));
 }
 
 
+ASSEMBLER_TEST_GENERATE(Beq_forward_taken_far, assembler) {
+  Label l;
+
+  __ set_use_far_branches(true);
+
+  __ LoadImmediate(T5, 1);
+  __ LoadImmediate(T6, 1);
+
+  __ LoadImmediate(V0, 42);
+  __ beq(T5, T6, &l);
+  __ LoadImmediate(V0, 0);
+  __ Bind(&l);
+  __ jr(RA);
+}
+
+
+ASSEMBLER_TEST_RUN(Beq_forward_taken_far, test) {
+  typedef int (*SimpleCode)();
+  EXPECT_EQ(42, EXECUTE_TEST_CODE_INT32(SimpleCode, test->entry()));
+}
+
+
 ASSEMBLER_TEST_GENERATE(Beq_forward_not_taken, assembler) {
   Label l;
 
   __ LoadImmediate(T5, 0);
   __ LoadImmediate(T6, 1);
 
   __ LoadImmediate(V0, 42);
   __ beq(T5, T6, &l);
+  __ nop();
   __ LoadImmediate(V0, 0);
   __ Bind(&l);
   __ jr(RA);
 }
 
 
 ASSEMBLER_TEST_RUN(Beq_forward_not_taken, test) {
   typedef int (*SimpleCode)();
   EXPECT_EQ(0, EXECUTE_TEST_CODE_INT32(SimpleCode, test->entry()));
 }
 
 
+ASSEMBLER_TEST_GENERATE(Beq_forward_not_taken_far, assembler) {
+  Label l;
+
+  __ set_use_far_branches(true);
+
+  __ LoadImmediate(T5, 0);
+  __ LoadImmediate(T6, 1);
+
+  __ LoadImmediate(V0, 42);
+  __ beq(T5, T6, &l);
+  __ nop();
+  __ LoadImmediate(V0, 0);
+  __ Bind(&l);
+  __ jr(RA);
+}
+
+
+ASSEMBLER_TEST_RUN(Beq_forward_not_taken_far, test) {
+  typedef int (*SimpleCode)();
+  EXPECT_EQ(0, EXECUTE_TEST_CODE_INT32(SimpleCode, test->entry()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(Beq_forward_not_taken_far2, assembler) {
+  Label l;
+
+  __ set_use_far_branches(true);
+
+  __ LoadImmediate(T5, 0);
+  __ LoadImmediate(T6, 1);
+
+  __ LoadImmediate(V0, 42);
+  __ beq(T5, T6, &l);
+  __ nop();
+  for (int i = 0; i < (1 << 15); i++) {
+    __ nop();
+  }
+  __ LoadImmediate(V0, 0);
+  __ Bind(&l);
+  __ jr(RA);
+}
+
+
+ASSEMBLER_TEST_RUN(Beq_forward_not_taken_far2, test) {
+  typedef int (*SimpleCode)();
+  EXPECT_EQ(0, EXECUTE_TEST_CODE_INT32(SimpleCode, test->entry()));
+}
+
+
 ASSEMBLER_TEST_GENERATE(Beq_forward_taken2, assembler) {
   Label l;
 
   __ LoadImmediate(T5, 1);
   __ LoadImmediate(T6, 1);
 
   __ LoadImmediate(V0, 42);
   __ beq(T5, T6, &l);
   __ nop();
   __ nop();
   __ LoadImmediate(V0, 0);
   __ Bind(&l);
   __ jr(RA);
 }
 
 
 ASSEMBLER_TEST_RUN(Beq_forward_taken2, test) {
   typedef int (*SimpleCode)();
   EXPECT_EQ(42, EXECUTE_TEST_CODE_INT32(SimpleCode, test->entry()));
 }
 
 
+ASSEMBLER_TEST_GENERATE(Beq_forward_taken_far2, assembler) {
+  Label l;
+
+  __ set_use_far_branches(true);
+
+  __ LoadImmediate(T5, 1);
+  __ LoadImmediate(T6, 1);
+
+  __ LoadImmediate(V0, 42);
+  __ beq(T5, T6, &l);
+  __ nop();
+  __ nop();
+  __ LoadImmediate(V0, 0);
+  __ Bind(&l);
+  __ jr(RA);
+}
+
+
+ASSEMBLER_TEST_RUN(Beq_forward_taken_far2, test) {
+  typedef int (*SimpleCode)();
+  EXPECT_EQ(42, EXECUTE_TEST_CODE_INT32(SimpleCode, test->entry()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(Beq_forward_taken_far3, assembler) {
+  Label l;
+
+  __ set_use_far_branches(true);
+
+  __ LoadImmediate(T5, 1);
+  __ LoadImmediate(T6, 1);
+
+  __ LoadImmediate(V0, 42);
+  __ beq(T5, T6, &l);
+  __ nop();
+  for (int i = 0; i < (1 << 15); i++) {
+    __ nop();
+  }
+  __ nop();
+  __ LoadImmediate(V0, 0);
+  __ Bind(&l);
+  __ jr(RA);
+}
+
+
+ASSEMBLER_TEST_RUN(Beq_forward_taken_far3, test) {
+  typedef int (*SimpleCode)();
+  EXPECT_EQ(42, EXECUTE_TEST_CODE_INT32(SimpleCode, test->entry()));
+}
+
+
 ASSEMBLER_TEST_GENERATE(Beq_forward_taken_delay, assembler) {
   Label l;
 
   __ LoadImmediate(T5, 1);
   __ LoadImmediate(T6, 1);
 
   __ LoadImmediate(V0, 42);
   __ beq(T5, T6, &l);
   __ delay_slot()->ori(V0, V0, Immediate(1));
   __ LoadImmediate(V0, 0);
@@ skipping 60 matching lines @@
   __ jr(RA);
 }
 
 
 ASSEMBLER_TEST_RUN(Bgez, test) {
   typedef int (*SimpleCode)();
   EXPECT_EQ(-2, EXECUTE_TEST_CODE_INT32(SimpleCode, test->entry()));
 }
 
 
+ASSEMBLER_TEST_GENERATE(Bgez_far, assembler) {
+  Label l;
+
+  __ set_use_far_branches(true);
+
+  __ LoadImmediate(T5, 3);
+  __ Bind(&l);
+  __ bgez(T5, &l);
+  __ delay_slot()->addiu(T5, T5, Immediate(-1));
+  __ ori(V0, T5, Immediate(0));
+  __ jr(RA);
+}
+
+
+ASSEMBLER_TEST_RUN(Bgez_far, test) {
+  typedef int (*SimpleCode)();
+  EXPECT_EQ(-2, EXECUTE_TEST_CODE_INT32(SimpleCode, test->entry()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(Bgez_far2, assembler) {
+  Label l;
+
+  __ set_use_far_branches(true);
+
+  __ LoadImmediate(T5, 3);
+  __ Bind(&l);
+  for (int i = 0; i < (1 << 15); i++) {
+    __ nop();
+  }
+  __ bgez(T5, &l);
+  __ delay_slot()->addiu(T5, T5, Immediate(-1));
+  __ ori(V0, T5, Immediate(0));
+  __ jr(RA);
+}
+
+
+ASSEMBLER_TEST_RUN(Bgez_far2, test) {
+  typedef int (*SimpleCode)();
+  EXPECT_EQ(-2, EXECUTE_TEST_CODE_INT32(SimpleCode, test->entry()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(Bgez_taken_forward_far, assembler) {
+  Label l;
+
+  __ set_use_far_branches(true);
+
+  __ LoadImmediate(T5, 1);
+
+  __ LoadImmediate(V0, 42);
+  __ bgez(T5, &l);
+  __ nop();
+  __ nop();
+  __ LoadImmediate(V0, 0);
+  __ Bind(&l);
+  __ jr(RA);
+}
+
+
+ASSEMBLER_TEST_RUN(Bgez_taken_forward_far, test) {
+  typedef int (*SimpleCode)();
+  EXPECT_EQ(42, EXECUTE_TEST_CODE_INT32(SimpleCode, test->entry()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(Bgez_taken_forward_far2, assembler) {
+  Label l;
+
+  __ set_use_far_branches(true);
+
+  __ LoadImmediate(T5, 1);
+
+  __ LoadImmediate(V0, 42);
+  __ bgez(T5, &l);
+  __ nop();
+  for (int i = 0; i < (1 << 15); i++) {
+    __ nop();
+  }
+  __ LoadImmediate(V0, 0);
+  __ Bind(&l);
+  __ jr(RA);
+}
+
+
+ASSEMBLER_TEST_RUN(Bgez_taken_forward_far2, test) {
+  typedef int (*SimpleCode)();
+  EXPECT_EQ(42, EXECUTE_TEST_CODE_INT32(SimpleCode, test->entry()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(Bgez_not_taken_forward_far, assembler) {
+  Label l;
+
+  __ set_use_far_branches(true);
+
+  __ LoadImmediate(T5, -1);
+
+  __ LoadImmediate(V0, 42);
+  __ bgez(T5, &l);
+  __ nop();
+  __ nop();
+  __ LoadImmediate(V0, 0);
+  __ Bind(&l);
+  __ jr(RA);
+}
+
+
+ASSEMBLER_TEST_RUN(Bgez_not_taken_forward_far, test) {
+  typedef int (*SimpleCode)();
+  EXPECT_EQ(0, EXECUTE_TEST_CODE_INT32(SimpleCode, test->entry()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(Bgez_not_taken_forward_far2, assembler) {
+  Label l;
+
+  __ set_use_far_branches(true);
+
+  __ LoadImmediate(T5, -1);
+
+  __ LoadImmediate(V0, 42);
+  __ bgez(T5, &l);
+  __ nop();
+  for (int i = 0; i < (1 << 15); i++) {
+    __ nop();
+  }
+  __ LoadImmediate(V0, 0);
+  __ Bind(&l);
+  __ jr(RA);
+}
+
+
+ASSEMBLER_TEST_RUN(Bgez_not_taken_forward_far2, test) {
+  typedef int (*SimpleCode)();
+  EXPECT_EQ(0, EXECUTE_TEST_CODE_INT32(SimpleCode, test->entry()));
+}
+
+
 ASSEMBLER_TEST_GENERATE(Bgezl, assembler) {
   Label l;
 
   __ LoadImmediate(T5, 3);
   __ Bind(&l);
   __ bgezl(T5, &l);
   __ delay_slot()->addiu(T5, T5, Immediate(-1));
   __ ori(V0, T5, Immediate(0));
   __ jr(RA);
 }
@@ skipping 16 matching lines @@
   __ jr(RA);
 }
 
 
 ASSEMBLER_TEST_RUN(Blez, test) {
   typedef int (*SimpleCode)();
   EXPECT_EQ(2, EXECUTE_TEST_CODE_INT32(SimpleCode, test->entry()));
 }
 
 
+ASSEMBLER_TEST_GENERATE(Blez_far, assembler) {
+  Label l;
+
+  __ set_use_far_branches(true);
+
+  __ LoadImmediate(T5, -3);
+  __ Bind(&l);
+  __ blez(T5, &l);
+  __ delay_slot()->addiu(T5, T5, Immediate(1));
+  __ ori(V0, T5, Immediate(0));
+  __ jr(RA);
+}
+
+
+ASSEMBLER_TEST_RUN(Blez_far, test) {
+  typedef int (*SimpleCode)();
+  EXPECT_EQ(2, EXECUTE_TEST_CODE_INT32(SimpleCode, test->entry()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(Blez_far2, assembler) {
+  Label l;
+
+  __ set_use_far_branches(true);
+
+  __ LoadImmediate(T5, -3);
+  __ Bind(&l);
+  for (int i = 0; i < (1 << 15); i++) {
+    __ nop();
+  }
+  __ blez(T5, &l);
+  __ delay_slot()->addiu(T5, T5, Immediate(1));
+  __ ori(V0, T5, Immediate(0));
+  __ jr(RA);
+}
+
+
+ASSEMBLER_TEST_RUN(Blez_far2, test) {
+  typedef int (*SimpleCode)();
+  EXPECT_EQ(2, EXECUTE_TEST_CODE_INT32(SimpleCode, test->entry()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(Blez_taken_forward_far, assembler) {
+  Label l;
+
+  __ set_use_far_branches(true);
+
+  __ LoadImmediate(T5, -1);
+
+  __ LoadImmediate(V0, 42);
+  __ blez(T5, &l);
+  __ nop();
+  __ nop();
+  __ LoadImmediate(V0, 0);
+  __ Bind(&l);
+  __ jr(RA);
+}
+
+
+ASSEMBLER_TEST_RUN(Blez_taken_forward_far, test) {
+  typedef int (*SimpleCode)();
+  EXPECT_EQ(42, EXECUTE_TEST_CODE_INT32(SimpleCode, test->entry()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(Blez_not_taken_forward_far, assembler) {
+  Label l;
+
+  __ set_use_far_branches(true);
+
+  __ LoadImmediate(T5, 1);
+
+  __ LoadImmediate(V0, 42);
+  __ blez(T5, &l);
+  __ nop();
+  __ nop();
+  __ LoadImmediate(V0, 0);
+  __ Bind(&l);
+  __ jr(RA);
+}
+
+
+ASSEMBLER_TEST_RUN(Blez_not_taken_forward_far, test) {
+  typedef int (*SimpleCode)();
+  EXPECT_EQ(0, EXECUTE_TEST_CODE_INT32(SimpleCode, test->entry()));
+}
+
+
 ASSEMBLER_TEST_GENERATE(Blezl, assembler) {
   Label l;
 
   __ LoadImmediate(T5, -3);
   __ Bind(&l);
   __ blezl(T5, &l);
   __ delay_slot()->addiu(T5, T5, Immediate(1));
   __ ori(V0, T5, Immediate(0));
   __ jr(RA);
 }
@@ skipping 777 matching lines @@
                      A1);
   __ lw(RA, Address(SP, 0 * kWordSize));
   __ lw(CTX, Address(SP, 1 * kWordSize));
   __ addiu(SP, SP, Immediate(2 * kWordSize));
   __ Ret();
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_MIPS