Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 107293006: Merge 163151 "Allow resource loads inside page unload events" (Closed)

Created:
7 years ago by Nate Chapin
Modified:
7 years ago
Reviewers:
Nate Chapin
CC:
blink-reviews
Visibility:
Public.

Description

Merge 163151 "Allow resource loads inside page unload events" > Allow resource loads inside page unload events > > https://src.chromium.org/viewvc/blink?revision=154852&view=revision appears > to have inadvertently caused ResourceFetcher::shouldLoadNewResource() to return > false inside of unload events. This is because activeDocumentLoader() has > switched to the provisional document loader, but the request is coming from > the committed document loader. > > Test written by sigbjornf@opera.com > > BUG=321241 > TEST=http/tests/xmlhttprequest/xmlhttprequest-unload-sync.html > > Review URL: https://codereview.chromium.org/102353004 TBR=japhet@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163450

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, --2 lines) Patch
A + LayoutTests/http/tests/xmlhttprequest/resources/xmlhttprequest-in-unload-sync.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-unload-sync.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-unload-sync-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Nate Chapin
7 years ago (2013-12-09 18:40:29 UTC) #1
Nate Chapin
7 years ago (2013-12-09 18:41:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r163450.

Powered by Google App Engine
This is Rietveld 408576698