NetworkPanel: Make "sticky" behavior explicit.

Source/devtools/front_end/NetworkPanel.js

 /*
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 68 matching lines @@
     WebInspector.networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.RequestUpdated, this._onRequestUpdated, this);
     WebInspector.networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.RequestFinished, this._onRequestUpdated, this);
 
     WebInspector.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.WillReloadPage, this._willReloadPage, this);
     WebInspector.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.MainFrameNavigated, this._mainFrameNavigated, this);
     WebInspector.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.Load, this._loadEventFired, this);
     WebInspector.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.DOMContentLoaded, this._domContentLoadedEventFired, this);
 
     this._addFilters();
     this._initializeView();
+    this._recordButton.toggled = true;
+    WebInspector.networkLog.requests.forEach(this._appendRequest.bind(this));
 }
 
 WebInspector.NetworkLogView.HTTPSchemas = {"http": true, "https": true, "ws": true, "wss": true};
 WebInspector.NetworkLogView._responseHeaderColumns = ["Cache-Control", "Connection", "Content-Encoding", "Content-Length", "ETag", "Keep-Alive", "Last-Modified", "Server", "Vary"];
 WebInspector.NetworkLogView._defaultColumnsVisibility = {
     method: true, status: true, scheme: false, domain: false, type: true, initiator: true, cookies: false, setCookies: false, size: true, time: true,
     "Cache-Control": false, "Connection": false, "Content-Encoding": false, "Content-Length": false, "ETag": false, "Keep-Alive": false, "Last-Modified": false, "Server": false, "Vary": false
 };
 WebInspector.NetworkLogView._defaultRefreshDelay = 500;
 
@@ skipping 42 matching lines @@
         // Enable faster hint.
         this._popoverHelper.setTimeout(100);
 
         this.calculator = new WebInspector.NetworkTransferTimeCalculator();
 
         this.switchToDetailedView();
     },
 
     get statusBarItems()
     {
-        return [this._recordButton.element, this._clearButton.element, this._filterBar.filterButton(), this._largerRequestsButton.element, this._progressBarContainer];
+        return [this._recordButton.element, this._clearButton.element, this._filterBar.filterButton(), this._largerRequestsButton.element, this._preserveLogCheckbox.element, this._progressBarContainer];
     },
 
     get useLargeRows()
     {
         return WebInspector.settings.resourcesLargeRows.get();
     },
 
     set allowPopover(flag)
     {
         this._allowPopover = flag;
@@ skipping 454 matching lines @@
     {
         this._recordButton = new WebInspector.StatusBarButton(WebInspector.UIString("Record Network Log"), "record-profile-status-bar-item");
         this._recordButton.addEventListener("click", this._onRecordButtonClicked, this);
 
         this._clearButton = new WebInspector.StatusBarButton(WebInspector.UIString("Clear"), "clear-status-bar-item");
         this._clearButton.addEventListener("click", this._reset, this);
 
         this._largerRequestsButton = new WebInspector.StatusBarButton(WebInspector.UIString("Use small resource rows."), "network-larger-resources-status-bar-item");
         this._largerRequestsButton.toggled = WebInspector.settings.resourcesLargeRows.get();
         this._largerRequestsButton.addEventListener("click", this._toggleLargerRequests, this);
+
+        this._preserveLogCheckbox = new WebInspector.StatusBarCheckbox(WebInspector.UIString("Preserve log"));
     },
 
     _loadEventFired: function(event)
     {
         if (!this._recordButton.toggled)
             return;
-         if (!this._userInitiatedRecording)
-            this._recordButton.toggled = false;
 
         this._mainRequestLoadTime = event.data || -1;
         // Schedule refresh to update boundaries and draw the new line.
         this._scheduleRefresh();
     },
 
     _domContentLoadedEventFired: function(event)
     {
         if (!this._recordButton.toggled)
             return;
@@ skipping 58 matching lines @@
         this._sortItems();
         this._updateSummaryBar();
         this._dataGrid.updateWidths();
         // FIXME: evaluate performance impact of moving this before a call to sortItems()
         if (wasScrolledToLastRow)
             this._dataGrid.scrollToLastRow();
     },
 
     _onRecordButtonClicked: function(e)
     {
+        if (!this._recordButton.toggled)
+            this._reset();
         this._recordButton.toggled = !this._recordButton.toggled;
-        this._userInitiatedRecording = this._recordButton.toggled;
-        delete this._truncateLogAfterNavigation;
     },
 
     _reset: function()
     {
         this.dispatchEventToListeners(WebInspector.NetworkLogView.EventTypes.ViewCleared);
 
         this._clearSearchMatchedList();
         if (this._popoverHelper)
             this._popoverHelper.hidePopover();
 
@@ skipping 72 matching lines @@
     _refreshRequest: function(request)
     {
         if (!this._requestsById[request.requestId])
             return;
         this._staleRequests[request.requestId] = request;
         this._scheduleRefresh();
     },
 
     _willReloadPage: function(event)
     {
-        if (this._userInitiatedRecording)
-            return;
-        if (!this.isShowing())
+        if (this._recordButton.toggled)

[vsevik, 2013/12/06 10:12:30]

These is redundant.

[eustas, 2013/12/06 10:47:12]

Done.

             return;
         this._recordButton.toggled = true;
-        this._truncateLogAfterNavigation = true;
-        this._reset();
+        if (!this._preserveLogCheckbox.checked())
+            this._reset();
     },
 
     /**
      * @param {WebInspector.Event} event
      */
     _mainFrameNavigated: function(event)
     {
-        if (!this._truncateLogAfterNavigation)
+        if (!this._recordButton.toggled || this._preserveLogCheckbox.checked())
             return;
-        delete this._truncateLogAfterNavigation;
 
         var frame = /** @type {WebInspector.ResourceTreeFrame} */ (event.data);
         var loaderId = frame.loaderId;
 
         // Pick provisional load requests.
         var requestsToPick = [];
         var requests = WebInspector.networkLog.requests;
         for (var i = 0; i < requests.length; ++i) {
             var request = requests[i];
             if (request.loaderId === loaderId)
@@ skipping 1715 matching lines @@
 WebInspector.NetworkDataGridNode.RequestPropertyComparator = function(propertyName, revert, a, b)
 {
     var aValue = a._request[propertyName];
     var bValue = b._request[propertyName];
     if (aValue > bValue)
         return revert ? -1 : 1;
     if (bValue > aValue)
         return revert ? 1 : -1;
     return 0;
 }