Issue 107293005: NetworkPanel: Make "sticky" behavior explicit.

Issue 107293005: NetworkPanel: Make "sticky" behavior explicit. (Closed)

Created:
7 years ago by eustas

Modified:
7 years ago

Reviewers:
vsevik, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

NetworkPanel: Make "sticky" behavior explicit. BUG=325878 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163331

Patch Set 1 #

Total comments: 8

Patch Set 2 : Polish #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -60 lines)			Patch
D	LayoutTests/http/tests/inspector/network/network-auto-record.html	View		1 chunk	+0 lines, -42 lines	0 comments	Download
D	LayoutTests/http/tests/inspector/network/network-auto-record-expected.txt	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	Source/devtools/front_end/NetworkPanel.js	View	1 2 3 4	6 chunks	+10 lines, -13 lines	0 comments	Download
M	Source/devtools/front_end/StatusBarButton.js	View		1 chunk	+26 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/inspector.css	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

vsevik

https://chromiumcodereview.appspot.com/107293005/diff/1/Source/devtools/front_end/NetworkPanel.js File Source/devtools/front_end/NetworkPanel.js (right): https://chromiumcodereview.appspot.com/107293005/diff/1/Source/devtools/front_end/NetworkPanel.js#newcode153 Source/devtools/front_end/NetworkPanel.js:153: return [this._recordButton.element, this._stickyCheckbox.element, this._clearButton.element, this._filterBar.filterButton(), this._largerRequestsButton.element, this._progressBarContainer]; Move after ...

7 years ago (2013-12-06 09:58:52 UTC) #2

eustas

https://codereview.chromium.org/107293005/diff/1/Source/devtools/front_end/NetworkPanel.js File Source/devtools/front_end/NetworkPanel.js (right): https://codereview.chromium.org/107293005/diff/1/Source/devtools/front_end/NetworkPanel.js#newcode153 Source/devtools/front_end/NetworkPanel.js:153: return [this._recordButton.element, this._stickyCheckbox.element, this._clearButton.element, this._filterBar.filterButton(), this._largerRequestsButton.element, this._progressBarContainer]; On 2013/12/06 ...

7 years ago (2013-12-06 10:05:43 UTC) #3

vsevik

https://chromiumcodereview.appspot.com/107293005/diff/50001/Source/devtools/front_end/NetworkPanel.js File Source/devtools/front_end/NetworkPanel.js (right): https://chromiumcodereview.appspot.com/107293005/diff/50001/Source/devtools/front_end/NetworkPanel.js#newcode809 Source/devtools/front_end/NetworkPanel.js:809: if (this._recordButton.toggled) These is redundant.

7 years ago (2013-12-06 10:12:30 UTC) #4

eustas

https://codereview.chromium.org/107293005/diff/50001/Source/devtools/front_end/NetworkPanel.js File Source/devtools/front_end/NetworkPanel.js (right): https://codereview.chromium.org/107293005/diff/50001/Source/devtools/front_end/NetworkPanel.js#newcode809 Source/devtools/front_end/NetworkPanel.js:809: if (this._recordButton.toggled) On 2013/12/06 10:12:30, vsevik wrote: > These ...

7 years ago (2013-12-06 10:47:12 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/107293005/70001

7 years ago (2013-12-06 10:57:34 UTC) #7

Message was sent while issue was closed.

Change committed as 163331

Expand Messages | Collapse Messages