Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Issue 107293002: Update not-reviewed-by-human poppler baselines (Closed)

Created:
7 years ago by epoger
Modified:
6 years, 10 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Update not-reviewed-by-human poppler baselines BUG=skia:1657, skia:1578 TBR=vandebo These were already annotated as belonging to https://code.google.com/p/skia/issues/detail?id=1578 ('commit GM actuals as expectations for all tests, marking them as unreviewed'), which means they had not been visually reviewed in the first place. So we have no reason to believe their current results are incorrect (for all we know, they were wrong before) For these and all other expectations with the bug1578 annotation, we should figure out a way to validate them. But that's for another day... Committed: https://code.google.com/p/skia/source/detail?r=12521

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+646 lines, -646 lines) Patch
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 30 chunks +30 lines, -30 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 9 chunks +9 lines, -9 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 29 chunks +29 lines, -29 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 6 chunks +6 lines, -6 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 30 chunks +30 lines, -30 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 13 chunks +13 lines, -13 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 30 chunks +30 lines, -30 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 3 chunks +3 lines, -3 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 31 chunks +31 lines, -31 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 11 chunks +11 lines, -11 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 31 chunks +31 lines, -31 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 3 chunks +3 lines, -3 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86-Debug/expected-results.json View 31 chunks +31 lines, -31 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86-Release/expected-results.json View 32 chunks +32 lines, -32 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Debug/expected-results.json View 29 chunks +29 lines, -29 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release/expected-results.json View 29 chunks +29 lines, -29 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-NoGPU-x86_64-Debug/expected-results.json View 30 chunks +30 lines, -30 lines 0 comments Download
M expectations/gm/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN/expected-results.json View 31 chunks +31 lines, -31 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-ANGLE/expected-results.json View 30 chunks +30 lines, -30 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-DirectWrite/expected-results.json View 29 chunks +29 lines, -29 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug/expected-results.json View 30 chunks +30 lines, -30 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-ANGLE/expected-results.json View 30 chunks +30 lines, -30 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-DirectWrite/expected-results.json View 29 chunks +29 lines, -29 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json View 30 chunks +30 lines, -30 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Debug/expected-results.json View 30 chunks +30 lines, -30 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Release/expected-results.json View 30 chunks +30 lines, -30 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
epoger
Committed patchset #1 manually as r12521 (presubmit successful).
7 years ago (2013-12-05 22:07:21 UTC) #1
epoger
committed TBR
7 years ago (2013-12-05 22:07:49 UTC) #2
epoger
7 years ago (2013-12-05 22:08:25 UTC) #3
On 2013/12/05 22:07:49, epoger wrote:
> committed TBR

A glance at the diffs will indicate that all of the affected results are
associated with bug 1578.  I made sure of this in the rebaseline_server UI.

Powered by Google App Engine
This is Rietveld 408576698