Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 1072923003: Serializer: canonicalize cleared weak cells. (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Serializer: canonicalize cleared weak cells. R=hpayer@chromium.org BUG=v8:4050 LOG=N

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M src/heap/heap.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/snapshot/serialize.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/snapshot/serialize.cc View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Yang
5 years, 8 months ago (2015-04-21 12:42:54 UTC) #1
Hannes Payer (out of office)
lgtm from my side ulan, is that fine with you
5 years, 8 months ago (2015-04-21 12:48:56 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072923003/20001
5 years, 8 months ago (2015-04-21 12:50:17 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/5106)
5 years, 8 months ago (2015-04-21 12:52:10 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 12:53:08 UTC) #11
Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1072923003/1

Powered by Google App Engine
This is Rietveld 408576698