Issue 1072913002: Subzero: Use a "deterministic" random shuffle for register allocation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1072913002: Subzero: Use a "deterministic" random shuffle for register allocation. (Closed)

Created:
5 years, 8 months ago by Jim Stichnoth

Modified:
5 years, 8 months ago

Reviewers:
jvoung (off chromium), Mircea Trofin

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Subzero: Use a "deterministic" random shuffle for register allocation. To make this work, Subzero provides its own RandomShuffle() as a replacement for std::random_shuffle(), and the Subzero implementation doesn't depend on the stdlib implementation. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4129 R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=caef3486222c75612ff3ae97bc9b6a6619796c17

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -23 lines)			Patch
M	src/IceRNG.h	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/IceTargetLoweringX8632.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests_lit/llvm2ice_tests/randomize-regalloc.ll	View	4 chunks	+21 lines, -21 lines	0 comments	Download
M	unittest/IceELFSectionTest.cpp	View	1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Jim Stichnoth

5 years, 8 months ago (2015-04-09 18:19:42 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
caef3486222c75612ff3ae97bc9b6a6619796c17 (presubmit successful).