Fix node validation for SVG foreignobject tag

tests/html/node_validator_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library validator_test;
 
 import 'dart:async';
 import 'dart:html';
 import 'dart:svg' as svg;
 import 'package:unittest/unittest.dart';
@@ skipping 168 matching lines @@
     checkUriPolicyCalls('q::cite',
         '<q cite="s"></q>',
         '<q></q>',
         ['s']);
     checkUriPolicyCalls('video::poster',
         '<video poster="s"/>',
         '<video/>',
         ['s']);
   });
 
-  group('NodeValidationPolicy', () {
-
-    group('allowNavigation', () {
-      var validator = new NodeValidatorBuilder()..allowNavigation();
-
-      testHtml('allows anchor tags',
+  group('allowNavigation', () {
+    var validator = new NodeValidatorBuilder()..allowNavigation();
+
+    testHtml('allows anchor tags',
+        validator,
+        '<a href="#foo">foo</a>');
+
+    testHtml('allows form elements',
+        validator,
+        '<form method="post" action="/foo"></form>');
+
+    testHtml('disallows script navigation',
+        validator,
+        '<a href="javascript:foo = 1">foo</a>',
+        '<a>foo</a>');
+
+    testHtml('disallows cross-site navigation',
+        validator,
+        '<a href="http://example.com">example.com</a>',
+        '<a>example.com</a>');
+
+    testHtml('blocks other elements',
+        validator,
+        '<a href="#foo"><b>foo</b></a>',
+        '<a href="#foo"></a>');
+
+    testHtml('blocks tag extension',
+        validator,
+        '<a is="x-foo"></a>',
+        '');
+  });
+
+  group('allowImages', () {
+    var validator = new NodeValidatorBuilder()..allowImages();
+
+    testHtml('allows images',
+        validator,
+        '<img src="/foo.jpg" alt="something" width="100" height="100"/>');
+
+    testHtml('blocks onerror',
+        validator,
+        '<img src="/foo.jpg" onerror="something"/>',
+        '<img src="/foo.jpg"/>');
+
+    testHtml('enforces same-origin',
+        validator,
+        '<img src="http://example.com/foo.jpg"/>',
+        '<img/>');
+  });
+
+  group('allowCustomElement', () {
+    var validator = new NodeValidatorBuilder()
+      ..allowCustomElement(
+          'x-foo',
+          attributes: ['bar'],
+          uriAttributes: ['baz'])
+      ..allowHtml5();
+
+    testHtml('allows custom elements',
+        validator,
+        '<x-foo bar="something" baz="/foo.jpg"></x-foo>');
+
+
+    testHtml('validates custom tag URIs',
+        validator,
+        '<x-foo baz="http://example.com/foo.jpg"></x-foo>',
+        '<x-foo></x-foo>');
+
+    testHtml('blocks type extensions',
+        validator,
+        '<div is="x-foo"></div>',
+        '');
+
+    testHtml('blocks tags on non-matching elements',
+        validator,
+        '<div bar="foo"></div>',
+        '<div></div>');
+  });
+
+  group('allowTagExtension', () {
+     var validator = new NodeValidatorBuilder()
+      ..allowTagExtension(
+          'x-foo',
+          'div',
+          attributes: ['bar'],
+          uriAttributes: ['baz'])
+      ..allowHtml5();
+
+    testHtml('allows tag extensions',
+        validator,
+        '<div is="x-foo" bar="something" baz="/foo.jpg"></div>');
+
+    testHtml('blocks custom elements',
           validator,
-          '<a href="#foo">foo</a>');
-
-      testHtml('allows form elements',
-          validator,
-          '<form method="post" action="/foo"></form>');
-
-      testHtml('disallows script navigation',
-          validator,
-          '<a href="javascript:foo = 1">foo</a>',
-          '<a>foo</a>');
-
-      testHtml('disallows cross-site navigation',
-          validator,
-          '<a href="http://example.com">example.com</a>',
-          '<a>example.com</a>');
-
-      testHtml('blocks other elements',
-          validator,
-          '<a href="#foo"><b>foo</b></a>',
-          '<a href="#foo"></a>');
-
-      testHtml('blocks tag extension',
-          validator,
-          '<a is="x-foo"></a>',
+          '<x-foo></x-foo>',
           '');
-    });
-
-    group('allowImages', () {
-      var validator = new NodeValidatorBuilder()..allowImages();
-
-      testHtml('allows images',
-          validator,
-          '<img src="/foo.jpg" alt="something" width="100" height="100"/>');
-
-      testHtml('blocks onerror',
-          validator,
-          '<img src="/foo.jpg" onerror="something"/>',
-          '<img src="/foo.jpg"/>');
-
-      testHtml('enforces same-origin',
-          validator,
-          '<img src="http://example.com/foo.jpg"/>',
-          '<img/>');
-    });
-
-    group('allowCustomElement', () {
-      var validator = new NodeValidatorBuilder()
-        ..allowCustomElement(
-            'x-foo',
-            attributes: ['bar'],
-            uriAttributes: ['baz'])
-        ..allowHtml5();
-
-      testHtml('allows custom elements',
-          validator,
-          '<x-foo bar="something" baz="/foo.jpg"></x-foo>');
-
-
-      testHtml('validates custom tag URIs',
-          validator,
-          '<x-foo baz="http://example.com/foo.jpg"></x-foo>',
-          '<x-foo></x-foo>');
-
-      testHtml('blocks type extensions',
-          validator,
-          '<div is="x-foo"></div>',
-          '');
-
-      testHtml('blocks tags on non-matching elements',
-          validator,
-          '<div bar="foo"></div>',
-          '<div></div>');
-    });
-
-    group('allowTagExtension', () {
-       var validator = new NodeValidatorBuilder()
-        ..allowTagExtension(
-            'x-foo',
-            'div',
-            attributes: ['bar'],
-            uriAttributes: ['baz'])
-        ..allowHtml5();
-
-      testHtml('allows tag extensions',
-          validator,
-          '<div is="x-foo" bar="something" baz="/foo.jpg"></div>');
-
-      testHtml('blocks custom elements',
-            validator,
-            '<x-foo></x-foo>',
-            '');
-
-      testHtml('validates tag extension URIs',
-          validator,
-          '<div is="x-foo" baz="http://example.com/foo.jpg"></div>',
-          '<div is="x-foo"></div>');
-
-      testHtml('blocks tags on non-matching elements',
-          validator,
-          '<div bar="foo"></div>',
-          '<div></div>');
-
-      testHtml('blocks non-matching tags',
-          validator,
-          '<span is="x-foo">something</span>',
-          '');
-
-      validator = new NodeValidatorBuilder()
-        ..allowTagExtension(
-            'x-foo',
-            'div',
-            attributes: ['bar'],
-            uriAttributes: ['baz'])
-        ..allowTagExtension(
-            'x-else',
-            'div');
-
-      testHtml('blocks tags on non-matching custom elements',
-          validator,
-          '<div bar="foo" is="x-else"></div>',
-          '<div is="x-else"></div>');
-    });
-
-    group('allowTemplating', () {
-      var validator = new NodeValidatorBuilder()
-        ..allowTemplating()
-        ..allowHtml5();
-
-      testHtml('allows templates',
-          validator,
-          '<template bind="{{a}}"></template>');
-
-      testHtml('allows template attributes',
-          validator,
-          '<template bind="{{a}}" ref="foo" repeat="{{}}" if="{{}}" syntax="foo"></template>');
-
-      testHtml('allows template attribute',
-          validator,
-          '<div template repeat="{{}}"></div>');
-
-      testHtml('blocks illegal template attribute',
-          validator,
-          '<div template="foo" repeat="{{}}"></div>',
-          '<div></div>');
-    });
-
-    group('allowSvg', () {
-      var validator = new NodeValidatorBuilder()..allowSvg();
-
-      testHtml('allows basic SVG',
-        validator,
-        '<svg xmlns="http://www.w3.org/2000/svg'
-            'xmlns:xlink="http://www.w3.org/1999/xlink">'
-          '<image xlink:href="foo" data-foo="bar"/>'
-        '</svg>');
-
-      testHtml('blocks script elements',
-        validator,
-        '<svg xmlns="http://www.w3.org/2000/svg>'
-          '<script></script>'
-        '</svg>',
-        '<svg xmlns="http://www.w3.org/2000/svg></svg>');
-
-      testHtml('blocks script handlers',
-        validator,
-        '<svg xmlns="http://www.w3.org/2000/svg'
-            'xmlns:xlink="http://www.w3.org/1999/xlink">'
-          '<image xlink:href="foo" onerror="something"/>'
-        '</svg>',
-        '<svg xmlns="http://www.w3.org/2000/svg'
-            'xmlns:xlink="http://www.w3.org/1999/xlink">'
-          '<image xlink:href="foo"/>'
-        '</svg>');
-
-      testHtml('blocks foreignObject content',
-        validator,
-        '<svg xmlns="http://www.w3.org/2000/svg">'
-          '<foreignobject width="100" height="150">'
-            '<body xmlns="http://www.w3.org/1999/xhtml">'
-              '<div>Some content</div>'
-            '</body>'
-          '</foreignobject>'
-          '<number>42</number>'
-        '</svg>',
-        '<svg xmlns="http://www.w3.org/2000/svg">'
-          '<number>42</number>'
-        '</svg>');
-    });
-
-    group('allowInlineStyles', () {
-      var validator = new NodeValidatorBuilder()
-          ..allowTextElements()
-          ..allowInlineStyles();
-
-      testHtml('allows inline styles',
-          validator,
-          '<span style="background-color:red">text</span>');
-
-      testHtml('blocks other attributes',
-          validator,
-          '<span class="red-span"></span>',
-          '<span></span>');
-
-      validator = new NodeValidatorBuilder()
-          ..allowTextElements()
-          ..allowInlineStyles(tagName: 'span');
-
-      testHtml('scoped allows inline styles on spans',
-          validator,
-          '<span style="background-color:red">text</span>');
-
-      testHtml('scoped blocks inline styles on LIs',
-          validator,
-          '<li style="background-color:red">text</li>',
-          '<li>text</li>');
-    });
+
+    testHtml('validates tag extension URIs',
+        validator,
+        '<div is="x-foo" baz="http://example.com/foo.jpg"></div>',
+        '<div is="x-foo"></div>');
+
+    testHtml('blocks tags on non-matching elements',
+        validator,
+        '<div bar="foo"></div>',
+        '<div></div>');
+
+    testHtml('blocks non-matching tags',
+        validator,
+        '<span is="x-foo">something</span>',
+        '');
+
+    validator = new NodeValidatorBuilder()
+      ..allowTagExtension(
+          'x-foo',
+          'div',
+          attributes: ['bar'],
+          uriAttributes: ['baz'])
+      ..allowTagExtension(
+          'x-else',
+          'div');
+
+    testHtml('blocks tags on non-matching custom elements',
+        validator,
+        '<div bar="foo" is="x-else"></div>',
+        '<div is="x-else"></div>');
+  });
+
+  group('allowTemplating', () {
+    var validator = new NodeValidatorBuilder()
+      ..allowTemplating()
+      ..allowHtml5();
+
+    testHtml('allows templates',
+        validator,
+        '<template bind="{{a}}"></template>');
+
+    testHtml('allows template attributes',
+        validator,
+        '<template bind="{{a}}" ref="foo" repeat="{{}}" if="{{}}" syntax="foo"></template>');
+
+    testHtml('allows template attribute',
+        validator,
+        '<div template repeat="{{}}"></div>');
+
+    testHtml('blocks illegal template attribute',
+        validator,
+        '<div template="foo" repeat="{{}}"></div>',
+        '<div></div>');
+  });
+
+  group('allowSvg', () {
+    var validator = new NodeValidatorBuilder()
+      ..allowSvg()
+      ..allowTextElements();
+
+    testHtml('allows basic SVG',
+      validator,
+      '<svg xmlns="http://www.w3.org/2000/svg'
+          'xmlns:xlink="http://www.w3.org/1999/xlink">'
+        '<image xlink:href="foo" data-foo="bar"/>'
+      '</svg>');
+
+    testHtml('blocks script elements',
+      validator,
+      '<svg xmlns="http://www.w3.org/2000/svg>'
+        '<script></script>'
+      '</svg>',
+      '<svg xmlns="http://www.w3.org/2000/svg></svg>');
+
+    testHtml('blocks script handlers',
+      validator,
+      '<svg xmlns="http://www.w3.org/2000/svg'
+          'xmlns:xlink="http://www.w3.org/1999/xlink">'
+        '<image xlink:href="foo" onerror="something"/>'
+      '</svg>',
+      '<svg xmlns="http://www.w3.org/2000/svg'
+          'xmlns:xlink="http://www.w3.org/1999/xlink">'
+        '<image xlink:href="foo"/>'
+      '</svg>');
+
+    testHtml('blocks foreignObject content',
+      validator,
+      '<svg xmlns="http://www.w3.org/2000/svg">'
+        '<foreignobject width="100" height="150">'
+          '<body xmlns="http://www.w3.org/1999/xhtml">'
+            '<div>Some content</div>'
+          '</body>'
+        '</foreignobject>'
+        '<b>42</b>'
+      '</svg>',
+      '<svg xmlns="http://www.w3.org/2000/svg">'
+        '<b>42</b>'
+      '</svg>');
+  });
+
+  group('allowInlineStyles', () {
+    var validator = new NodeValidatorBuilder()
+        ..allowTextElements()
+        ..allowInlineStyles();
+
+    testHtml('allows inline styles',
+        validator,
+        '<span style="background-color:red">text</span>');
+
+    testHtml('blocks other attributes',
+        validator,
+        '<span class="red-span"></span>',
+        '<span></span>');
+
+    validator = new NodeValidatorBuilder()
+        ..allowTextElements()
+        ..allowInlineStyles(tagName: 'span');
+
+    testHtml('scoped allows inline styles on spans',
+        validator,
+        '<span style="background-color:red">text</span>');
+
+    testHtml('scoped blocks inline styles on LIs',
+        validator,
+        '<li style="background-color:red">text</li>',
+        '<li>text</li>');
   });
 
   group('throws', () {
     var validator = new NodeValidator.throws(new NodeValidatorBuilder.common());
 
     var validationError = throwsArgumentError;
 
     test('does not throw on valid syntax', () {
       expect(() {
         document.body.createFragment('<div></div>', validator: validator);
@@ skipping 29 matching lines @@
           '<image xlink:href="foo" data-foo="bar"/>'
         '</svg>';
 
       var fragment = new DocumentFragment.svg(svgText);
       var element = fragment.nodes.first;
       expect(element is svg.SvgSvgElement, isTrue);
       expect(element.children[0] is svg.ImageElement, isTrue);
     });
   });
 }