Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: runtime/bin/file_linux.cc

Issue 107283003: Nit fix: 1024 -> KB. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/globals.h" 5 #include "platform/globals.h"
6 #if defined(TARGET_OS_LINUX) 6 #if defined(TARGET_OS_LINUX)
7 7
8 #include "bin/file.h" 8 #include "bin/file.h"
9 9
10 #include <errno.h> // NOLINT 10 #include <errno.h> // NOLINT
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
242 int result = 1; 242 int result = 1;
243 while (result > 0) { 243 while (result > 0) {
244 // Loop to ensure we copy everything, and not only up to 2GB. 244 // Loop to ensure we copy everything, and not only up to 2GB.
245 result = TEMP_FAILURE_RETRY( 245 result = TEMP_FAILURE_RETRY(
246 sendfile64(new_fd, old_fd, &offset, kMaxUint32)); 246 sendfile64(new_fd, old_fd, &offset, kMaxUint32));
247 } 247 }
248 // From sendfile man pages: 248 // From sendfile man pages:
249 // Applications may wish to fall back to read(2)/write(2) in the case 249 // Applications may wish to fall back to read(2)/write(2) in the case
250 // where sendfile() fails with EINVAL or ENOSYS. 250 // where sendfile() fails with EINVAL or ENOSYS.
251 if (result < 0 && (errno == EINVAL || errno == ENOSYS)) { 251 if (result < 0 && (errno == EINVAL || errno == ENOSYS)) {
252 const intptr_t kBufferSize = 8 * 1024; 252 const intptr_t kBufferSize = 8 * KB;
253 uint8_t buffer[kBufferSize]; 253 uint8_t buffer[kBufferSize];
254 while ((result = TEMP_FAILURE_RETRY( 254 while ((result = TEMP_FAILURE_RETRY(
255 read(old_fd, buffer, kBufferSize))) > 0) { 255 read(old_fd, buffer, kBufferSize))) > 0) {
256 int wrote = TEMP_FAILURE_RETRY(write(new_fd, buffer, result)); 256 int wrote = TEMP_FAILURE_RETRY(write(new_fd, buffer, result));
257 if (wrote != result) { 257 if (wrote != result) {
258 result = -1; 258 result = -1;
259 break; 259 break;
260 } 260 }
261 } 261 }
262 } 262 }
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
409 return (file_1_info.st_ino == file_2_info.st_ino && 409 return (file_1_info.st_ino == file_2_info.st_ino &&
410 file_1_info.st_dev == file_2_info.st_dev) ? 410 file_1_info.st_dev == file_2_info.st_dev) ?
411 File::kIdentical : 411 File::kIdentical :
412 File::kDifferent; 412 File::kDifferent;
413 } 413 }
414 414
415 } // namespace bin 415 } // namespace bin
416 } // namespace dart 416 } // namespace dart
417 417
418 #endif // defined(TARGET_OS_LINUX) 418 #endif // defined(TARGET_OS_LINUX)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698