Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1072823002: Revert of Reland of 'Make allow_subannotations more robust' (Closed)

Created:
5 years, 8 months ago by kjellander_chromium
Modified:
5 years, 8 months ago
Reviewers:
iannucci, luqui
CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Revert of Reland of 'Make allow_subannotations more robust' (patchset #2 id:20001 of https://codereview.chromium.org/1076643002/) Reason for revert: Makes the WebRTC Windows perf bots hang when the upload to the perf dashboard is about to happen. Examples: http://build.chromium.org/p/client.webrtc/builders/Win32%20Release%20%5Blarge%20tests%5D http://build.chromium.org/p/chromium.webrtc.fyi/builders/Win7%20Tester http://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester http://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester For some strange reason it only affects Win7 and 8, not XP. Original issue's description: > Reland of 'Make allow_subannotations more robust' > > From here: http://crrev.com/1001183002#ps120001 > > This patch makes the recipe engine parse and re-emit subannotations when allow_subannotations is True. This means that any of the subannotator's steps which are duplicates of other steps executed will be disambiguated. When an allow_subannotations step is actually emits annotations, an (end) step is emitted after it is done to have something to hang metadata on (it also conveniently communicates when we re-enter recipes). > > BUG=466409 > R=iannucci@chromium.org > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294732 TBR=iannucci@chromium.org,luqui@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=466409 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294738

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -291 lines) Patch
M scripts/common/annotator.py View 6 chunks +17 lines, -23 lines 0 comments Download
M scripts/slave/annotated_run.py View 10 chunks +62 lines, -152 lines 0 comments Download
M scripts/slave/recipe_modules/step/api.py View 2 chunks +9 lines, -0 lines 0 comments Download
D scripts/slave/recipes/example/subannotations.py View 1 chunk +0 lines, -48 lines 0 comments Download
D scripts/slave/recipes/example/subannotations.expected/basic.json View 1 chunk +0 lines, -67 lines 0 comments Download
M scripts/slave/unittests/recipe_simulation_test.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
kjellander_chromium
Created Revert of Reland of 'Make allow_subannotations more robust'
5 years, 8 months ago (2015-04-09 12:49:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072823002/1
5 years, 8 months ago (2015-04-09 12:49:58 UTC) #2
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 12:50:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294738

Powered by Google App Engine
This is Rietveld 408576698