Chromium Code Reviews Chromium Code Reviews
Issue 1072813002:
Avoid considering readonly password elements in password form (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/test/data/password/password_form_with_password_readonly.html |
| diff --git a/chrome/test/data/password/signup_form.html b/chrome/test/data/password/password_form_with_password_readonly.html |
| similarity index 66% |
| copy from chrome/test/data/password/signup_form.html |
| copy to chrome/test/data/password/password_form_with_password_readonly.html |
| index 0aca628f701536fbdf15ad793d9e67daaf0c6153..d31a26d5647519bd47a0dd904fa76c1151455019 100644 |
| --- a/chrome/test/data/password/signup_form.html |
| +++ b/chrome/test/data/password/password_form_with_password_readonly.html |
| @@ -1,13 +1,11 @@ |
| <!-- |
|
vabr (Chromium)
2015/04/10 08:04:51
Currently, git recognised this as branching off ch
ramya.v
2015/04/10 10:40:23
Done.
|
| - A mock signup form. Essentially the same as password_form.html, but includes |
| - an additional text field which will cause it to be treated differently. |
| + Form with password element readonly |
|
vabr (Chromium)
2015/04/10 08:04:51
nit: Reorder words and add a full stop:
Form with
ramya.v
2015/04/10 10:40:23
Done.
|
| --> |
| <html> |
| <body> |
| <form method="POST" action="done.html" onsubmit="return true;" id="testform"> |
| - <input type="text" id="other_info" name="other_info"> |
| <input type="text" id="username_field" name="username_field"> |
| - <input type="password" id="password_field" name="password_field"> |
| + <input type="password" readonly="readonly" id="password_field" name="password_field"> |
|
vabr (Chromium)
2015/04/10 08:04:51
nit: The readonly attribute does not require a val
ramya.v
2015/04/10 10:40:23
Done.
|
| <input type="submit" id="input_submit_button" name="input_submit_button"> |
| </form> |
