Avoid considering readonly password elements in password form

components/autofill/content/renderer/password_form_conversion_utils.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/password_form_conversion_utils.h"
 
 #include <vector>
 
 #include "base/lazy_instance.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 343 matching lines @@
       }
     }
     password_form->username_value = username_value;
   }
 
   WebInputElement password;
   WebInputElement new_password;
   if (!LocateSpecificPasswords(passwords, &password, &new_password))
     return;
 
+  // If Password field is readonly, there is no point in considering

[vabr (Chromium), 2015/04/10 08:04:51]

I suggest the following rephrasing, to better capture the reasons for not
supporting those forms for now:

// If the password field is readonly, the page is likely using a virtual
keyboard and bypassing the password field value (see http://crbug.com/475488).
There is nothing Chrome can do to fill passwords for now.

[ramya.v, 2015/04/10 10:40:23]

Done.

+  // such form for autofill e.g., m.epost.go.kr,
+  // where password field is associated with virtual keypad.
+  if (!password.isNull() && password.isReadOnly())

[vabr (Chromium), 2015/04/10 08:04:51]

Instead of doing this check here, I suggest moving adding this to the condition
on line 257. That way, the read-only passwords will not even be considered for
being used, and in case there are other, modifiable, password fields, Chrome
will try to use them.

There is a caveat, though, in case the readonly password element is explicitly
marked as a password field by an autocomplete attribute. To handle those
correctly, I suggest dropping this block, and changing the check on line 257 to

if (input_element->isPasswordField() && (!input_element.isReadInly() ||
HasAutocompleteAttributeValue(*input_element, "current-password") ||
HasAutocompleteAttributeValue(*input_element, "new-password")) {
...
}

[ramya.v, 2015/04/10 10:40:23]

Done.

+    return;
+
   password_form->action = GetCanonicalActionForForm(form);
   if (!password_form->action.is_valid())
     return;
 
   password_form->origin = GetCanonicalOriginForDocument(form.document());
   GURL::Replacements rep;
   rep.SetPathStr("");
   password_form->signon_realm =
       password_form->origin.ReplaceComponents(rep).spec();
   password_form->other_possible_usernames.swap(other_possible_usernames);
@@ skipping 69 matching lines @@
                            blink::WebFormControlElement(),
                            REQUIRE_NONE,
                            EXTRACT_NONE,
                            &password_form->form_data,
                            NULL /* FormFieldData */);
 
   return password_form.Pass();
 }
 
 }  // namespace autofill