Issue 1072783003: Remove server socket references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1072783003: Remove server socket references (Closed)

Created:
5 years, 8 months ago by Søren Gjesse

Modified:
5 years, 2 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

Remove server socket references The use of server socket references was deprecated in 1.9 and marked for removal in 1.10. R=kustermann@google.com BUG=http://dartbug.com/22187 Committed: https://github.com/dart-lang/sdk/commit/65872873d260950273b45bc3064eaab4e165b671

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -295 lines)			Patch
M	runtime/bin/io_natives.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/bin/socket.h	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	runtime/bin/socket.cc	View		2 chunks	+0 lines, -23 lines	0 comments	Download
M	runtime/bin/socket_patch.dart	View	1	4 chunks	+0 lines, -57 lines	0 comments	Download
M	sdk/lib/io/socket.dart	View		2 chunks	+0 lines, -69 lines	0 comments	Download
D	tests/standalone/io/server_socket_reference_issue21383_and_issue21384_test.dart	View		1 chunk	+0 lines, -73 lines	0 comments	Download
M	tests/standalone/io/socket_bind_test.dart	View		2 chunks	+0 lines, -65 lines	0 comments	Download

Total messages: 3 (0 generated)

kustermann

lgtm - but we could - as discussed offline - also push it to the ...

5 years, 8 months ago (2015-04-09 15:12:39 UTC) #2

Søren Gjesse

5 years, 2 months ago (2015-10-05 10:25:30 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
65872873d260950273b45bc3064eaab4e165b671 (presubmit successful).