Issue 1072763002: (WONT COMMIT) FetchAPI: Make GlobalFetchImpl non-templated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1072763002: (WONT COMMIT) FetchAPI: Make GlobalFetchImpl non-templated (Closed)

Created:
5 years, 8 months ago by nhiroki

Modified:
5 years, 8 months ago

Reviewers:

CC:
blink-reviews, yhirano, horo

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

FetchAPI: Make GlobalFetchImpl non-templated This is a preparation patch for [1]. Templatization would be cumbersome to expose the interface in that CL. [1] https://codereview.chromium.org/1065093006/ BUG=440295 TEST=compile

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -8 lines)			Patch
	M	Source/modules/fetch/GlobalFetch.cpp	View		3 chunks	+18 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

nhiroki

5 years, 8 months ago (2015-04-20 05:28:03 UTC) #3

Let me recall this CL for now because probably I'll change the design.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages