Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 107273002: Merge 236134 "Ensure that the first browser window which is crea..." (Closed)

Created:
7 years ago by ananta
Modified:
7 years ago
Reviewers:
ananta
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Merge 236134 "Ensure that the first browser window which is crea..." > Ensure that the first browser window which is created in Windows 8 ASH is maximized. > > This is done via the Ash WindowPositioner class. The change is in the WindowPositioner::GetBoundsAndShowStateForNewWindow > function which for windows returns SHOW_STATE_MAXIMIZED if this is the first window being opened. > > Based on a discussion with oshima, I enabled the WindowSizerAshTest ash unit tests for Windows. There were a number > of places in the WindowSizer class where we were allowing browsers to be in ASH only for Chrome OS. Checking for > the host desktop type should be enough. This was needed to get the window to be maximized for ASH. > > Fixes bug http://crbug.com/231603 > > BUG=231603 > R=cpu@chromium.org, oshima@chromium.org, sky@chromium.org, cpu, oshima, sky > > Review URL: https://codereview.chromium.org/62333015 TBR=ananta@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239046

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -36 lines) Patch
M ash/test/ash_test_base.cc View 2 chunks +17 lines, -14 lines 0 comments Download
M ash/wm/window_positioner.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/wm/window_positioner.cc View 3 chunks +11 lines, -3 lines 0 comments Download
M ash/wm/window_positioner_unittest.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc View 3 chunks +20 lines, -6 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
7 years ago (2013-12-05 21:56:35 UTC) #1
ananta
7 years ago (2013-12-05 21:57:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r239046.

Powered by Google App Engine
This is Rietveld 408576698