Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: chrome/test/BUILD.gn

Issue 1072653005: Update gn_all and gyp_remaining to reflect reality on the win config. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn_all
Patch Set: fix breakpad-related issues Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« BUILD.gn ('K') | « build/gn_migration.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/BUILD.gn
diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
index 6e367da20ce9c8dec1d7999674f72af4ce5ab3dd..deafcc6a2acfd374ce9c05b2308abccf08571295 100644
--- a/chrome/test/BUILD.gn
+++ b/chrome/test/BUILD.gn
@@ -1681,7 +1681,7 @@ if (!is_android) {
}
}
- if (is_linux && !is_chromeos) {
+ if (is_win || (is_linux && !is_chromeos)) {
# TODO(GYP): Figure out which of these work and are needed on other
# platforms.
test("chrome_app_unittests") {
@@ -1702,6 +1702,7 @@ if (!is_android) {
deps = [
":test_support",
+ "//breakpad:client",
"//chrome/browser",
"//chrome/child",
"//base/test:run_all_unittests",
« BUILD.gn ('K') | « build/gn_migration.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698