Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 1072653005: Update gn_all and gyp_remaining to reflect reality on the win config. (Closed)

Created:
5 years, 8 months ago by Dirk Pranke
Modified:
5 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn_all
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update gn_all and gyp_remaining to reflect reality on the win config. R=brettw@chromium.org BUG=354261 CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel Committed: https://crrev.com/fd181327c65aa69010eeaa2b1190334eedd82325 Cr-Commit-Position: refs/heads/master@{#324948}

Patch Set 1 #

Patch Set 2 : merge to head #

Patch Set 3 : clean up comments, move symupload #

Patch Set 4 : put generate_test_gn_data back in #

Patch Set 5 : fix breakpad-related issues #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -123 lines) Patch
M BUILD.gn View 1 2 3 4 15 chunks +127 lines, -87 lines 1 comment Download
M base/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M build/gn_migration.gypi View 1 2 13 chunks +45 lines, -34 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 20 (8 generated)
Dirk Pranke
note that this depends on the initial gn_all/gyp_remaining patch for win that was reverted. It ...
5 years, 8 months ago (2015-04-09 03:01:02 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072653005/40001
5 years, 8 months ago (2015-04-11 00:57:06 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/77349) chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 8 months ago (2015-04-11 01:37:44 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072653005/60001
5 years, 8 months ago (2015-04-11 01:52:20 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/55688)
5 years, 8 months ago (2015-04-11 02:01:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072653005/80001
5 years, 8 months ago (2015-04-13 21:29:35 UTC) #12
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 8 months ago (2015-04-13 21:29:38 UTC) #14
brettw
rs lgtm https://codereview.chromium.org/1072653005/diff/80001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1072653005/diff/80001/BUILD.gn#newcode11 BUILD.gn:11: import("//build/config/crypto.gni") Long-term, this structure is unfortunate since ...
5 years, 8 months ago (2015-04-13 21:31:45 UTC) #15
Dirk Pranke
On 2015/04/13 21:31:45, brettw wrote: > rs lgtm > > https://codereview.chromium.org/1072653005/diff/80001/BUILD.gn > File BUILD.gn (right): ...
5 years, 8 months ago (2015-04-13 21:34:26 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072653005/80001
5 years, 8 months ago (2015-04-13 21:34:59 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 8 months ago (2015-04-13 23:56:12 UTC) #19
commit-bot: I haz the power
5 years, 8 months ago (2015-04-13 23:58:07 UTC) #20
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/fd181327c65aa69010eeaa2b1190334eedd82325
Cr-Commit-Position: refs/heads/master@{#324948}

Powered by Google App Engine
This is Rietveld 408576698