Issue 1072643002: sign-in: Don't inject into none http/https page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1072643002: sign-in: Don't inject into none http/https page. (Closed)

Created:
5 years, 8 months ago by xiyuan

Modified:
5 years, 8 months ago

Reviewers:
Dmitry Polukhin

CC:
chromium-reviews, arv+watch_chromium.org, Roger Tawa OOO till Jul 10th, noms (inactive)

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

sign-in: Don't inject into none http/https page. BUG=473077 Committed: https://crrev.com/5c35815d434a2baf00573a39fcb547e4901384d3 Cr-Commit-Position: refs/heads/master@{#324368}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome/browser/resources/gaia_auth_host/saml_handler.js	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

xiyuan

Only http/https pages are interesting for Saml case. Thus only injecting code there. This would ...

5 years, 8 months ago (2015-04-08 21:39:00 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072643002/1

5 years, 8 months ago (2015-04-09 02:58:22 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-09 04:18:08 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/5c35815d434a2baf00573a39fcb547e4901384d3
Cr-Commit-Position: refs/heads/master@{#324368}