Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1072633002: Mark SkPictureRecorder::endRecording as SK_WARN_UNUSED_RESULT. (Closed)

Created:
5 years, 8 months ago by jbroman
Modified:
5 years, 8 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Mark SkPictureRecorder::endRecording as SK_WARN_UNUSED_RESULT. Ignoring the result is a memory leak. Callers should always at least unref the result. This bug has occurred in Blink: https://codereview.chromium.org/1068413002/ BUG=skia:3680 Committed: https://skia.googlesource.com/skia/+/7d1b945da6afdfb50372fd7b69153710d7793a52

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M include/core/SkPictureRecorder.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072633002/1
5 years, 8 months ago (2015-04-08 21:08:56 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-08 21:08:57 UTC) #3
mtklein
lgtm
5 years, 8 months ago (2015-04-08 21:09:44 UTC) #5
mtklein
+reed, who the CQ will want to LGTM this too.
5 years, 8 months ago (2015-04-08 21:12:21 UTC) #7
commit-bot: I haz the power
This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-08 21:28:12 UTC) #9
reed1
lgtm
5 years, 8 months ago (2015-04-09 13:11:28 UTC) #10
reed1
we should consider this for all of our factory-ish methods (and factories)
5 years, 8 months ago (2015-04-09 13:11:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072633002/1
5 years, 8 months ago (2015-04-09 13:12:08 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 13:12:23 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7d1b945da6afdfb50372fd7b69153710d7793a52

Powered by Google App Engine
This is Rietveld 408576698