pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart - Issue 1072623002: refactor optype to better filter invocation/prefixed suggestions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart

Issue 1072623002: refactor optype to better filter invocation/prefixed suggestions (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merge Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/optype.dart ('k') | pkg/analysis_server/test/services/completion/optype_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart b/pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart

index 10c69c19643fd8ceef79cc2241f950ef6c125e05..cb6ccf42fd1604791458245f2087cc2ae03cedd4 100644

--- a/pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart

+++ b/pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart

@@ -27,7 +27,7 @@ class PrefixedElementContributor extends DartCompletionContributor {

@override

bool computeFast(DartCompletionRequest request) {

OpType optype = request.optype;

- if (optype.includeInvocationSuggestions) {

+ if (optype.isPrefixed) {

builder = request.target.containingNode

.accept(new _InvocationAstVisitor(request));

if (builder != null) {