Issue 1072613003: Consider platform-specific expected .png files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1072613003: Consider platform-specific expected .png files. (Closed)

Created:
5 years, 8 months ago by Tom Sepez

Modified:
5 years, 8 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com, brucedawson

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Consider platform-specific expected .png files. Rolls DEPS to pull in the first windows-specific .png files, and unsupresses the corresponding tests. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/308e05e5f06bd8daabaed12c211f6e072810f8de

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -6 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	testing/SUPPRESSIONS_win	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	testing/tools/pngdiffer.py	View	2 chunks	+11 lines, -3 lines	0 comments	Download

Total messages: 5 (1 generated)

Tom Sepez

5 years, 8 months ago (2015-04-09 19:35:06 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
308e05e5f06bd8daabaed12c211f6e072810f8de (presubmit successful).