Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1072603002: Add GM to repro crbug.com/472795 (Closed)

Created:
5 years, 8 months ago by robertphillips
Modified:
5 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add GM to repro crbug.com/472795 This CL also adds a new parameter to SkBitmapSource which gives the user control of the filter quality. BUG=472795 Committed: https://skia.googlesource.com/skia/+/e275fdf812b1dc09beaa3b14570eb0b641a07e6a

Patch Set 1 #

Total comments: 2

Patch Set 2 : renamed filter to filterQuality #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -8 lines) Patch
A gm/bitmapsource2.cpp View 1 chunk +90 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/effects/SkBitmapSource.h View 1 3 chunks +9 lines, -4 lines 0 comments Download
M src/effects/SkBitmapSource.cpp View 1 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
robertphillips
5 years, 8 months ago (2015-04-08 20:14:14 UTC) #2
Stephen White
LGTM https://codereview.chromium.org/1072603002/diff/1/include/effects/SkBitmapSource.h File include/effects/SkBitmapSource.h (right): https://codereview.chromium.org/1072603002/diff/1/include/effects/SkBitmapSource.h#newcode33 include/effects/SkBitmapSource.h:33: SkFilterQuality filter); Nit: filter -> filterQuality? (filter's kinda ...
5 years, 8 months ago (2015-04-08 20:40:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072603002/20001
5 years, 8 months ago (2015-04-09 12:59:32 UTC) #7
robertphillips
https://codereview.chromium.org/1072603002/diff/1/include/effects/SkBitmapSource.h File include/effects/SkBitmapSource.h (right): https://codereview.chromium.org/1072603002/diff/1/include/effects/SkBitmapSource.h#newcode33 include/effects/SkBitmapSource.h:33: SkFilterQuality filter); On 2015/04/08 20:40:11, Stephen White wrote: > ...
5 years, 8 months ago (2015-04-09 12:59:36 UTC) #9
commit-bot: I haz the power
Presubmit check for 1072603002-20001 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 8 months ago (2015-04-09 12:59:37 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072603002/20001
5 years, 8 months ago (2015-04-09 13:00:24 UTC) #12
commit-bot: I haz the power
This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-09 13:07:22 UTC) #14
reed1
might update CL desc to also mention the API change to bitmapsource. lgtm
5 years, 8 months ago (2015-04-09 13:24:24 UTC) #16
robertphillips
I've updated the CL description.
5 years, 8 months ago (2015-04-09 13:46:39 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072603002/20001
5 years, 8 months ago (2015-04-09 13:47:02 UTC) #19
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 13:47:18 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e275fdf812b1dc09beaa3b14570eb0b641a07e6a

Powered by Google App Engine
This is Rietveld 408576698