Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Unified Diff: cc/layers/delegated_renderer_layer_impl.cc

Issue 1072563002: cc: Move the quad validation checks to the place quads are inserted. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/delegated_renderer_layer_impl.cc
diff --git a/cc/layers/delegated_renderer_layer_impl.cc b/cc/layers/delegated_renderer_layer_impl.cc
index 0da42131794dfd50ccd063e65c3c8bb4f6cb3dbe..dfbb826a4a5446e9aa8dfce37894af8a414f6903 100644
--- a/cc/layers/delegated_renderer_layer_impl.cc
+++ b/cc/layers/delegated_renderer_layer_impl.cc
@@ -474,6 +474,9 @@ void DelegatedRendererLayerImpl::AppendRenderPassQuads(
DrawQuad* output_quad = render_pass->CopyFromAndAppendDrawQuad(
delegated_quad, output_shared_quad_state);
output_quad->visible_rect = quad_visible_rect;
+ // TODO(danakj): crbug.com/455931
+ output_quad->IterateResources(base::Bind(
+ &ValidateResource, layer_tree_impl()->resource_provider()));
} else {
RenderPassId delegated_contributing_render_pass_id =
RenderPassDrawQuad::MaterialCast(delegated_quad)->render_pass_id;
@@ -494,12 +497,12 @@ void DelegatedRendererLayerImpl::AppendRenderPassQuads(
output_shared_quad_state,
output_contributing_render_pass_id);
output_quad->visible_rect = quad_visible_rect;
+
+ // TODO(danakj): crbug.com/455931
+ output_quad->IterateResources(base::Bind(
+ &ValidateResource, layer_tree_impl()->resource_provider()));
}
}
-
- // TODO(danakj): crbug.com/455931
- render_pass->quad_list.back()->IterateResources(
- base::Bind(&ValidateResource, layer_tree_impl()->resource_provider()));
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698