Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1072563002: cc: Move the quad validation checks to the place quads are inserted. (Closed)

Created:
5 years, 8 months ago by danakj
Modified:
5 years, 8 months ago
Reviewers:
enne (OOO), piman
CC:
enne (OOO), cc-bugs_chromium.org, chromium-reviews, vmpstr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Move the quad validation checks to the place quads are inserted. It's possible that DelegatedRendererLayerImpl decides to not append a quad if it's not valid. In that case it could crash trying to validate the non-existant quad. R=piman@chromium.org BUG=475099 Committed: https://crrev.com/f4bb78ba1e15f8be8a3943bedfe9a5f52c4ef42c Cr-Commit-Position: refs/heads/master@{#324278}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M cc/layers/delegated_renderer_layer_impl.cc View 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
danakj
5 years, 8 months ago (2015-04-08 17:57:24 UTC) #2
enne (OOO)
lgtm
5 years, 8 months ago (2015-04-08 18:44:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072563002/1
5 years, 8 months ago (2015-04-08 18:44:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-08 20:09:48 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 20:10:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4bb78ba1e15f8be8a3943bedfe9a5f52c4ef42c
Cr-Commit-Position: refs/heads/master@{#324278}

Powered by Google App Engine
This is Rietveld 408576698