Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1072523002: Devtools: allow multiple custom formatters (Closed)

Created:
5 years, 8 months ago by sergeyv
Modified:
5 years, 2 months ago
Reviewers:
donder2335, pfeldman
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools: allow multiple custom formatters BUG=476307 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193475

Patch Set 1 #

Patch Set 2 : Test added #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -18 lines) Patch
A LayoutTests/inspector/console/console-custom-formatters.html View 1 1 chunk +99 lines, -0 lines 0 comments Download
A LayoutTests/inspector/console/console-custom-formatters-expected.txt View 1 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/inspector/InjectedScriptSource.js View 1 chunk +16 lines, -9 lines 0 comments Download
M Source/devtools/front_end/components/CustomPreviewSection.js View 3 chunks +5 lines, -8 lines 0 comments Download
M Source/devtools/protocol.json View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (3 generated)
sergeyv
5 years, 8 months ago (2015-04-08 15:43:52 UTC) #2
pfeldman
Please add a test.
5 years, 8 months ago (2015-04-08 17:32:50 UTC) #3
sergeyv
On 2015/04/08 17:32:50, pfeldman wrote: > Please add a test. Done.
5 years, 8 months ago (2015-04-09 13:42:03 UTC) #4
pfeldman
lgtm
5 years, 8 months ago (2015-04-09 13:56:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072523002/20001
5 years, 8 months ago (2015-04-09 17:36:09 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=193475
5 years, 8 months ago (2015-04-09 20:28:52 UTC) #8
donder2335
lgtm
5 years, 2 months ago (2015-10-21 05:34:28 UTC) #10
donder2335
lgtm lgtm
5 years, 2 months ago (2015-10-21 05:34:30 UTC) #11
donder2335
lgtm lgtm lgtm
5 years, 2 months ago (2015-10-21 05:34:30 UTC) #12
donder2335
lgtm lgtm lgtm lgtm
5 years, 2 months ago (2015-10-21 05:34:30 UTC) #13
donder2335
5 years, 2 months ago (2015-10-21 05:34:30 UTC) #14
Message was sent while issue was closed. 
lgtm

lgtm

lgtm

lgtm

lgtm

Powered by Google App Engine
This is Rietveld 408576698