Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 1072483004: Handle huge values for cols/rows in frameset (Closed)

Created:
5 years, 8 months ago by rwlbuis
Modified:
5 years, 8 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Handle huge values for cols/rows in frameset The values for cols/rows in frameset can be bigger than the range of an unsigned int. In that case treat as invalid and return early. BUG=475007 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193826

Patch Set 1 #

Patch Set 2 : Resort to empty HTMLDimension on !ok #

Patch Set 3 : Add test #

Total comments: 1

Patch Set 4 : Add multiple invalid cols / rows test case #

Total comments: 1

Patch Set 5 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
A + LayoutTests/fast/frames/huge-cols-rows-values.html View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
A + LayoutTests/fast/frames/huge-cols-rows-values-expected.html View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
A LayoutTests/fast/frames/invalid-cols-rows-value.html View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/fast/frames/invalid-cols-rows-value-expected.html View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/html/HTMLDimension.cpp View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
rwlbuis
PTAL
5 years, 8 months ago (2015-04-14 00:57:52 UTC) #2
Julien - ping for review
lgtm https://codereview.chromium.org/1072483004/diff/40001/LayoutTests/fast/frames/huge-cols-rows-values.html File LayoutTests/fast/frames/huge-cols-rows-values.html (right): https://codereview.chromium.org/1072483004/diff/40001/LayoutTests/fast/frames/huge-cols-rows-values.html#newcode1 LayoutTests/fast/frames/huge-cols-rows-values.html:1: <frameset cols="5050548387" rows="5050548387"> Interestingly there is no visual ...
5 years, 8 months ago (2015-04-14 15:54:07 UTC) #3
Julien - ping for review
https://codereview.chromium.org/1072483004/diff/80001/LayoutTests/fast/frames/huge-cols-rows-values.html File LayoutTests/fast/frames/huge-cols-rows-values.html (left): https://codereview.chromium.org/1072483004/diff/80001/LayoutTests/fast/frames/huge-cols-rows-values.html#oldcode1 LayoutTests/fast/frames/huge-cols-rows-values.html:1: <frameset cols="" rows="1,1"> Also, let's add a DOCTYPE to ...
5 years, 8 months ago (2015-04-14 22:58:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072483004/100001
5 years, 8 months ago (2015-04-15 19:44:59 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 20:57:03 UTC) #9
Message was sent while issue was closed.
Committed patchset #5 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193826

Powered by Google App Engine
This is Rietveld 408576698