Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1072463002: Revert of VectorICs: Turn on vector ICs for LOAD and KEYED_LOAD cases. (Closed)

Created:
5 years, 8 months ago by mvstanton
Modified:
5 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of VectorICs: Turn on vector ICs for LOAD and KEYED_LOAD cases. (patchset #1 id:1 of https://codereview.chromium.org/1070653002/) Reason for revert: ARM test failure, need to investigate. Original issue's description: > VectorICs: Turn on vector ICs for LOAD and KEYED_LOAD cases. > > R=verwaest@chromium.org > BUG= > > Committed: https://crrev.com/2395eda3bb7aca938751938df76e01ac2b89b0a6 > Cr-Commit-Position: refs/heads/master@{#27657} TBR=verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/ab86a050ce5ee0e2f879a4cbb0fa6a693c533dc0 Cr-Commit-Position: refs/heads/master@{#27664}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
mvstanton
Created Revert of VectorICs: Turn on vector ICs for LOAD and KEYED_LOAD cases.
5 years, 8 months ago (2015-04-08 12:52:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072463002/1
5 years, 8 months ago (2015-04-08 12:52:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-08 12:52:47 UTC) #3
mvstanton
Hi Toon, reverting flag to investigate an ARM failure.
5 years, 8 months ago (2015-04-08 12:52:51 UTC) #4
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 12:53:02 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab86a050ce5ee0e2f879a4cbb0fa6a693c533dc0
Cr-Commit-Position: refs/heads/master@{#27664}

Powered by Google App Engine
This is Rietveld 408576698