Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 107243006: Correctly resolve forcibly context allocated parameters in debug-evaluate. (Closed)

Created:
7 years ago by Yang
Modified:
7 years ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Correctly resolve forcibly context allocated parameters in debug-evaluate. R=ulan@chromium.org BUG=325676 LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=18402

Patch Set 1 #

Patch Set 2 : reupload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -34 lines) Patch
M src/runtime.cc View 2 chunks +10 lines, -13 lines 0 comments Download
A + test/mjsunit/regress/regress-325676.js View 1 chunk +27 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yang
Please take a look.
7 years ago (2013-12-12 15:18:44 UTC) #1
aandrey
On 2013/12/12 15:18:44, Yang wrote: > Please take a look. please re-upload
7 years ago (2013-12-12 15:20:09 UTC) #2
Yang
On 2013/12/12 15:20:09, aandrey wrote: > On 2013/12/12 15:18:44, Yang wrote: > > Please take ...
7 years ago (2013-12-12 15:22:45 UTC) #3
ulan
lgtm
7 years ago (2013-12-16 09:59:55 UTC) #4
Yang
7 years ago (2013-12-23 08:37:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r18402 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698