net/http/http_network_layer_unittest.cc - Issue 1072423005: Set network_accessed earlier, when network transaction creates stream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_network_layer_unittest.cc

Issue 1072423005: Set network_accessed earlier, when network transaction creates stream. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't break build on iOS Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_network_layer_unittest.cc

diff --git a/net/http/http_network_layer_unittest.cc b/net/http/http_network_layer_unittest.cc

index c49d5ec00e9f04d22f18822c8db6a2b85a745b97..9128cdd3da87986fb716c65ed757404437abd595 100644

--- a/net/http/http_network_layer_unittest.cc

+++ b/net/http/http_network_layer_unittest.cc

@@ -395,9 +395,8 @@ TEST_F(HttpNetworkLayerTest, NetworkUnVerified) {

rv = trans->Start(&request_info, callback.callback(), BoundNetLog());

ASSERT_EQ(ERR_CONNECTION_RESET, callback.GetResult(rv));

- // If the response info is null, that means that any consumer won't

- // see the network accessed bit set.

- EXPECT_EQ(NULL, trans->GetResponseInfo());

+ // network_accessed is true; the HTTP stack did try to make a connection.

+ EXPECT_TRUE(trans->GetResponseInfo()->network_accessed);

}

} // namespace

« no previous file with comments | « net/http/http_cache_transaction.cc ('k') | net/http/http_network_transaction.cc » ('j') | no next file with comments »