Stop flipping Help Icon in Hebrew Locale

ash/system/date/date_default_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/date/date_default_view.h"
 
 #include "ash/metrics/user_metrics_recorder.h"
 #include "ash/session/session_state_delegate.h"
 #include "ash/shell.h"
 #include "ash/system/date/date_view.h"
 #include "ash/system/tray/special_popup_row.h"
 #include "ash/system/tray/system_tray_delegate.h"
 #include "ash/system/tray/tray_constants.h"
 #include "ash/system/tray/tray_popup_header_button.h"
 #include "ash/wm/lock_state_controller.h"
+#include "base/i18n/rtl.h"
 #include "grit/ash_resources.h"
 #include "grit/ash_strings.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/views/border.h"
 #include "ui/views/controls/button/button.h"
 #include "ui/views/layout/fill_layout.h"
 #include "ui/views/view.h"
 
 namespace {
 
+// The ISO-639 code for the Hebrew locale. The help icon asset is a '?' which is
+// not mirrored in this locale.
+const char kHebrewLocale[] = "he";
+
 const int kPaddingVertical = 19;
 
 }  // namespace
 
 namespace ash {
 
 DateDefaultView::DateDefaultView(ash::user::LoginStatus login)
     : help_button_(NULL),
       shutdown_button_(NULL),
       lock_button_(NULL),
@@ skipping 15 matching lines @@
   if (login == user::LOGGED_IN_LOCKED ||
       login == user::LOGGED_IN_NONE || userAddingRunning)
     return;
 
   date_view_->SetAction(TrayDate::SHOW_DATE_SETTINGS);
 
   help_button_ = new TrayPopupHeaderButton(
       this, IDR_AURA_UBER_TRAY_HELP, IDR_AURA_UBER_TRAY_HELP,
       IDR_AURA_UBER_TRAY_HELP_HOVER, IDR_AURA_UBER_TRAY_HELP_HOVER,
       IDS_ASH_STATUS_TRAY_HELP);
+  if (base::i18n::IsRTL() &&
+      base::i18n::GetConfiguredLocale() == kHebrewLocale) {
+    // The asset for the help button is a question mark '?'. Normally this asset
+    // is flipped in RTL locales, however Hebrew uses the LTR '?'. So the
+    // flipping must be disabled. (crbug.com/475237)
+    help_button_->EnableCanvasFlippingForRTLUI(false);
+  }
   help_button_->SetTooltipText(
       l10n_util::GetStringUTF16(IDS_ASH_STATUS_TRAY_HELP));
   view->AddButton(help_button_);
 
 #if !defined(OS_WIN)
   if (login != ash::user::LOGGED_IN_LOCKED) {
     shutdown_button_ = new TrayPopupHeaderButton(
         this, IDR_AURA_UBER_TRAY_SHUTDOWN, IDR_AURA_UBER_TRAY_SHUTDOWN,
         IDR_AURA_UBER_TRAY_SHUTDOWN_HOVER, IDR_AURA_UBER_TRAY_SHUTDOWN_HOVER,
         IDS_ASH_STATUS_TRAY_SHUTDOWN);
@@ skipping 64 matching lines @@
 void DateDefaultView::OnShutdownPolicyChanged(bool reboot_on_shutdown) {
   if (!shutdown_button_)
     return;
 
   shutdown_button_->SetTooltipText(l10n_util::GetStringUTF16(
       reboot_on_shutdown ? IDS_ASH_STATUS_TRAY_REBOOT
                          : IDS_ASH_STATUS_TRAY_SHUTDOWN));
 }
 
 }  // namespace ash