components/password_manager/core/browser/facet_manager.cc - Issue 1072413003: Add foundation for trimming the AffiliationDatabase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/facet_manager.cc

Issue 1072413003: Add foundation for trimming the AffiliationDatabase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Keep noncontroversial parts. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/facet_manager.h ('k') | components/password_manager/core/browser/facet_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/facet_manager.cc

diff --git a/components/password_manager/core/browser/facet_manager.cc b/components/password_manager/core/browser/facet_manager.cc

index ea84f50ea2dff47a0ba20b1461bfa3be4f37fbb6..a0e9e8667371d41689ca49145dd1e0df4b6efc9c 100644

--- a/components/password_manager/core/browser/facet_manager.cc

+++ b/components/password_manager/core/browser/facet_manager.cc

@@ -187,6 +187,11 @@ bool FacetManager::CanBeDiscarded() const {

GetMaximumKeepFreshUntilThreshold() <= clock_->Now();

}

+bool FacetManager::CanCachedDataBeDiscarded() const {

+ return GetMaximumKeepFreshUntilThreshold() <= clock_->Now() ||

+ !IsCachedDataFresh();

bool FacetManager::DoesRequireFetch() const {

return (!pending_requests_.empty() && !IsCachedDataFresh()) ||

GetNextRequiredFetchTimeDueToPrefetch() <= clock_->Now();