LayoutTests/svg/stroke/non-scaling-stroke-pattern-text.html - Issue 1072403010: SVG Text should respect non-scaling-stroke.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/svg/stroke/non-scaling-stroke-pattern-text.html

Issue 1072403010: SVG Text should respect non-scaling-stroke. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added test with paint server Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	fs 2015/04/22 13:31:41 The name of this is -pattern-, but since it fill The name of this is -pattern-, but since it fills with a gradient -gradient- seems more appropriate. Shanmuga Pandi 2015/04/22 14:00:06 Done. Show quoted text On 2015/04/22 13:31:41, fs wrote: > The name of this is -pattern-, but since it fills with a gradient -gradient- > seems more appropriate. Done.
	2 <svg>

	3 <linearGradient id="g" x2="0" y2="1">

	4 <stop offset="0" stop-color="red"/>
	fs 2015/04/22 13:31:41 I think we should use a more "boring" gradient her I think we should use a more "boring" gradient here to avoid issue with rounding on different platforms: <stop offset="0" stop-color="green"/> <stop offset="0.5" stop-color="green"/> <stop offset="0.5" stop-color="blue"/> <stop offset="1" stop-color="blue"/> (I also prefer to not use the color "red" if there nothing "wrong" when you see it.) Shanmuga Pandi 2015/04/22 14:00:06 Done. Show quoted text On 2015/04/22 13:31:41, fs wrote: > I think we should use a more "boring" gradient here to avoid issue with rounding > on different platforms: > > <stop offset="0" stop-color="green"/> > <stop offset="0.5" stop-color="green"/> > <stop offset="0.5" stop-color="blue"/> > <stop offset="1" stop-color="blue"/> > > (I also prefer to not use the color "red" if there nothing "wrong" when you see > it.) Done.
	5 <stop offset="1" stop-color="blue"/>

	6 </linearGradient>

	7 <g transform="scale(2 2)">

	8 <text x="0" y="50" fill="url(#g)" stroke="url(#g)" stroke-width="2" vector- effect="non-scaling-stroke" font-size="36">Hello</text>

	9 </g>

	10 </svg>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/svg/stroke/non-scaling-stroke-pattern-text-expected.html » ('j') | no next file with comments »