LayoutTests/svg/repaint/repaint-non-scaling-stroke-text.html - Issue 1072403010: SVG Text should respect non-scaling-stroke.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/svg/repaint/repaint-non-scaling-stroke-text.html

Issue 1072403010: SVG Text should respect non-scaling-stroke. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: changed from expected.html to expected.txt Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <html>

	3 <script src="../../fast/repaint/resources/text-based-repaint.js"></script>

	4 <script>

	5 window.testIsAsync = true;

	6 window.onload = runRepaintTest;

	7

	8 function repaintTest() {

	9 setTimeout(function() {

	10 document.getElementById('t').setAttribute("stroke", "blue");

	11 document.getElementById('t').setAttribute("vector-effect", "non-scaling-strok e");

	12 requestAnimationFrame(function() {

	13 if (window.testRunner)

	14 finishRepaintTest();

	15 });

	16 }, 0);

	17 };

	18 </script>

	19 <body>

	20 <svg>

	21 <g transform="scale(2 2)">
	fs 2015/04/23 08:24:22 Make this 0.5 instead so that the resulting stroke Make this 0.5 instead so that the resulting stroke ends up being larger. Probably make sense to double the stroke-width at the same time. Shanmuga Pandi 2015/04/23 08:51:33 Done. Show quoted text On 2015/04/23 08:24:22, fs wrote: > Make this 0.5 instead so that the resulting stroke ends up being larger. > Probably make sense to double the stroke-width at the same time. Done. fs 2015/04/23 09:11:33 Please also increase stroke-width. Show quoted text On 2015/04/23 08:51:33, Shanmuga Pandi wrote: > On 2015/04/23 08:24:22, fs wrote: > > Make this 0.5 instead so that the resulting stroke ends up being larger. > > Probably make sense to double the stroke-width at the same time. > > Done. Please also increase stroke-width.
	22 <text id="t" x="0" y="50" stroke="none" stroke-width="2" fill="none" font -size="36" vector-effect="none">Hello</text>
	fs 2015/04/23 08:24:22 Make x > 0 (10 perhaps?) so that the repaint rect Make x > 0 (10 perhaps?) so that the repaint rect isn't clipped. Shanmuga Pandi 2015/04/23 08:51:33 Done. Show quoted text On 2015/04/23 08:24:22, fs wrote: > Make x > 0 (10 perhaps?) so that the repaint rect isn't clipped. > Done.
	23 </g>

	24 </svg>

	25 </body>

	26 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/svg/repaint/repaint-non-scaling-stroke-text-expected.txt » ('j') | no next file with comments »