SVG Text should respect non-scaling-stroke.

Source/core/paint/SVGInlineTextBoxPainter.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/paint/SVGInlineTextBoxPainter.h"
 
 #include "core/dom/DocumentMarkerController.h"
 #include "core/dom/RenderedDocumentMarker.h"
 #include "core/editing/Editor.h"
@@ skipping 260 matching lines @@
             if (svgDecorationStyle.hasFill()) {
                 SkPaint fillPaint;
                 if (!SVGPaintContext::paintForLayoutObject(paintInfo, decorationStyle, *decorationRenderer, ApplyToFillMode, fillPaint))
                     break;
                 fillPaint.setAntiAlias(true);
                 paintInfo.context->drawPath(path.skPath(), fillPaint);
             }
             break;
         case PT_STROKE:
             if (svgDecorationStyle.hasVisibleStroke()) {
                 // FIXME: Non-scaling stroke is not applied here.

[fs, 2015/04/22 12:15:55]

Could you fix this too? (Other CL ok, using same bug probably too.)

[Shanmuga Pandi, 2015/04/22 13:08:35]

Yes. I can fix this too. Probably Other CL. Could you please provide some test
case to check this bug here to verify the fix incase?

[fs, 2015/04/22 13:31:41]

I think it should be sufficient to add text-decoration="underline" to <text> in
the test for CL to see the bug.

[Shanmuga Pandi, 2015/04/22 14:00:06]

Thanks for the test case , I will make another CL to fix this decoration bug.

                 SkPaint strokePaint;
                 if (!SVGPaintContext::paintForLayoutObject(paintInfo, decorationStyle, *decorationRenderer, ApplyToStrokeMode, strokePaint))
                     break;
                 strokePaint.setAntiAlias(true);
                 StrokeData strokeData;
                 SVGLayoutSupport::applyStrokeStyleToStrokeData(strokeData, decorationStyle, *decorationRenderer);
                 strokeData.setupPaint(&strokePaint);
                 paintInfo.context->drawPath(path.skPath(), strokePaint);
             }
             break;
@@ skipping 26 matching lines @@
     AffineTransform paintServerTransform;
     const AffineTransform* additionalPaintServerTransform = 0;
 
     GraphicsContextStateSaver stateSaver(*context, false);
     if (scalingFactor != 1) {
         textOrigin.scale(scalingFactor, scalingFactor);
         textSize.scale(scalingFactor);
         stateSaver.save();
         context->scale(1 / scalingFactor, 1 / scalingFactor);
         // Adjust the paint-server coordinate space.
         paintServerTransform.scale(scalingFactor);

[fs, 2015/04/22 12:15:55]

Make a test with a paint-server (gradient/pattern) too, because this may be
influenced by non-scaling-stroke as well.

[Shanmuga Pandi, 2015/04/22 13:08:35]

Added test case

         additionalPaintServerTransform = &paintServerTransform;
     }
 
     // FIXME: Non-scaling stroke is not applied here.

[fs, 2015/04/22 12:15:55]

Can remove this now.

[Shanmuga Pandi, 2015/04/22 13:08:35]

Done.

     SkPaint paint;
     if (!SVGPaintContext::paintForLayoutObject(paintInfo, style, m_svgInlineTextBox.parent()->layoutObject(), resourceMode, paint, additionalPaintServerTransform))
         return;
     paint.setAntiAlias(true);
 
     if (hasShadow) {
         OwnPtr<DrawLooperBuilder> drawLooperBuilder = shadowList->createDrawLooper(DrawLooperBuilder::ShadowRespectsAlpha);
         RefPtr<SkDrawLooper> drawLooper = drawLooperBuilder->detachDrawLooper();
         paint.setLooper(drawLooper.get());
     }
 
     if (resourceMode == ApplyToStrokeMode) {
         StrokeData strokeData;
         SVGLayoutSupport::applyStrokeStyleToStrokeData(strokeData, style, m_svgInlineTextBox.parent()->layoutObject());
-        strokeData.setThickness(strokeData.thickness() * scalingFactor);
+        if (style.svgStyle().vectorEffect() != VE_NON_SCALING_STROKE)
+            strokeData.setThickness(strokeData.thickness() * scalingFactor);
         strokeData.setupPaint(&paint);
     }
 
     TextRunPaintInfo textRunPaintInfo(textRun);
     textRunPaintInfo.from = startPosition;
     textRunPaintInfo.to = endPosition;
 
     float baseline = scaledFont.fontMetrics().floatAscent();
     textRunPaintInfo.bounds = FloatRect(textOrigin.x(), textOrigin.y() - baseline,
         textSize.width(), textSize.height());
@@ skipping 87 matching lines @@
                 if (!fragmentTransform.isIdentity())
                     context->concatCTM(fragmentTransform);
                 context->setFillColor(color);
                 context->fillRect(fragmentRect, color);
             }
         }
     }
 }
 
 } // namespace blink