Use std::vector<uint8_t> instead of uint8*/int for MediaKeys interface

Use std::vector<uint8_t> instead of uint8*/int for MediaKeys interface

BUG=433446
TEST=media_unittests and EME layout tests pass

Committed: https://crrev.com/f52b16ac4740888ce847620da41357824286a719
Cr-Commit-Position: refs/heads/master@{#326824}

[jrummell, 2015-04-21 01:03:28]

jrummell@chromium.org changed reviewers:
+ sandersd@chromium.org, xhwang@chromium.org

[jrummell, 2015-04-21 01:03:28]

PTAL.

[xhwang, 2015-04-21 04:47:11]

Looking good. Just have a few nits.

You also need to update Android, Mojo and possibly Cast code.

https://codereview.chromium.org/1072403009/diff/1/content/renderer/media/cryp...
File content/renderer/media/crypto/ppapi_decryptor.h (right):

https://codereview.chromium.org/1072403009/diff/1/content/renderer/media/cryp...
content/renderer/media/crypto/ppapi_decryptor.h:53: const std::vector<uint8>&
certificate,
use uint8_t

https://codereview.chromium.org/1072403009/diff/1/media/base/media_keys.h
File media/base/media_keys.h (right):

https://codereview.chromium.org/1072403009/diff/1/media/base/media_keys.h#new...
media/base/media_keys.h:151: const std::vector<uint8>& message,
use uint8_t here as well

https://codereview.chromium.org/1072403009/diff/1/media/blink/cdm_session_ada...
File media/blink/cdm_session_adapter.h (right):

https://codereview.chromium.org/1072403009/diff/1/media/blink/cdm_session_ada...
media/blink/cdm_session_adapter.h:46: void SetServerCertificate(const
std::vector<uint8>& server_certificate,
we use |ceritificate| in MediaKeys... would be great to be consistent

https://codereview.chromium.org/1072403009/diff/1/media/cdm/aes_decryptor.cc
File media/cdm/aes_decryptor.cc (right):

https://codereview.chromium.org/1072403009/diff/1/media/cdm/aes_decryptor.cc#...
media/cdm/aes_decryptor.cc:265: if (init_data.size() > 0) {
!empty()

https://codereview.chromium.org/1072403009/diff/1/media/cdm/aes_decryptor.cc#...
media/cdm/aes_decryptor.cc:275: init_data.size(), &keys)) {
Can you make GetKeyIdsForCommonSystemId() taking vector as well?

https://codereview.chromium.org/1072403009/diff/1/media/cdm/aes_decryptor.cc#...
media/cdm/aes_decryptor.cc:318: CHECK_GT(response.size(), 0u);
!empty()

[jrummell, 2015-04-21 22:59:36]

Updated to use uint8_t plus mojo changes. Android should already be covered with
ProxyMediaKeys, cast probably not. Kicked off the trybots to find out.

https://codereview.chromium.org/1072403009/diff/1/content/renderer/media/cryp...
File content/renderer/media/crypto/ppapi_decryptor.h (right):

https://codereview.chromium.org/1072403009/diff/1/content/renderer/media/cryp...
content/renderer/media/crypto/ppapi_decryptor.h:53: const std::vector<uint8>&
certificate,
On 2015/04/21 04:47:11, xhwang wrote:
> use uint8_t 

Done.

https://codereview.chromium.org/1072403009/diff/1/media/base/media_keys.h
File media/base/media_keys.h (right):

https://codereview.chromium.org/1072403009/diff/1/media/base/media_keys.h#new...
media/base/media_keys.h:151: const std::vector<uint8>& message,
On 2015/04/21 04:47:11, xhwang wrote:
> use uint8_t here as well

Done.

https://codereview.chromium.org/1072403009/diff/1/media/blink/cdm_session_ada...
File media/blink/cdm_session_adapter.h (right):

https://codereview.chromium.org/1072403009/diff/1/media/blink/cdm_session_ada...
media/blink/cdm_session_adapter.h:46: void SetServerCertificate(const
std::vector<uint8>& server_certificate,
On 2015/04/21 04:47:11, xhwang wrote:
> we use |ceritificate| in MediaKeys... would be great to be consistent

Done.

https://codereview.chromium.org/1072403009/diff/1/media/cdm/aes_decryptor.cc
File media/cdm/aes_decryptor.cc (right):

https://codereview.chromium.org/1072403009/diff/1/media/cdm/aes_decryptor.cc#...
media/cdm/aes_decryptor.cc:265: if (init_data.size() > 0) {
On 2015/04/21 04:47:11, xhwang wrote:
> !empty()

Done.

https://codereview.chromium.org/1072403009/diff/1/media/cdm/aes_decryptor.cc#...
media/cdm/aes_decryptor.cc:275: init_data.size(), &keys)) {
On 2015/04/21 04:47:11, xhwang wrote:
> Can you make GetKeyIdsForCommonSystemId() taking vector as well?

Done.

https://codereview.chromium.org/1072403009/diff/1/media/cdm/aes_decryptor.cc#...
media/cdm/aes_decryptor.cc:318: CHECK_GT(response.size(), 0u);
On 2015/04/21 04:47:11, xhwang wrote:
> !empty()

Done.

[jrummell, 2015-04-22 23:09:45]

Updated (rebase + more Android changes)

[xhwang, 2015-04-23 00:09:08]

On 2015/04/22 23:09:45, jrummell wrote:
> Updated (rebase + more Android changes)

Seems like some cast files need to be updated as well.

[xhwang, 2015-04-23 04:25:32]

lgtm % nit

https://codereview.chromium.org/1072403009/diff/60001/content/renderer/pepper...
File content/renderer/pepper/content_decryptor_delegate.cc (right):

https://codereview.chromium.org/1072403009/diff/60001/content/renderer/pepper...
content/renderer/pepper/content_decryptor_delegate.cc:420: certificate.size(),
vector_as_array(&certificate));
Here and wherever applicable, add include for vector_as_array

[jrummell, 2015-04-23 17:25:15]

jrummell@chromium.org changed reviewers:
+ bbudge@chromium.org, gunsch@chromium.org

[jrummell, 2015-04-23 17:25:16]

+bbudge@ for changes in content/renderer/pepper/
+gunsch@ for changes in chromecast/media/cdm/

https://codereview.chromium.org/1072403009/diff/60001/content/renderer/pepper...
File content/renderer/pepper/content_decryptor_delegate.cc (right):

https://codereview.chromium.org/1072403009/diff/60001/content/renderer/pepper...
content/renderer/pepper/content_decryptor_delegate.cc:420: certificate.size(),
vector_as_array(&certificate));
On 2015/04/23 04:25:31, xhwang wrote:
> Here and wherever applicable, add include for vector_as_array

Done.

[bbudge, 2015-04-23 17:35:39]

https://codereview.chromium.org/1072403009/diff/80001/content/renderer/pepper...
File content/renderer/pepper/content_decryptor_delegate.cc (right):

https://codereview.chromium.org/1072403009/diff/80001/content/renderer/pepper...
content/renderer/pepper/content_decryptor_delegate.cc:421: certificate.size(),
vector_as_array(&certificate));
You should probably have a base::checked_cast to narrow size_t to uint32_t here
and other call sites for MakeArrayBufferPPVar.

https://codereview.chromium.org/1072403009/diff/80001/content/renderer/pepper...
content/renderer/pepper/content_decryptor_delegate.cc:1220: static_cast<const
uint8_t*>(NULL));
As long as you're here, s/NULL/nullptr. Then you can eliminate the cast.

[jrummell, 2015-04-23 20:22:43]

Updated.

https://codereview.chromium.org/1072403009/diff/80001/content/renderer/pepper...
File content/renderer/pepper/content_decryptor_delegate.cc (right):

https://codereview.chromium.org/1072403009/diff/80001/content/renderer/pepper...
content/renderer/pepper/content_decryptor_delegate.cc:421: certificate.size(),
vector_as_array(&certificate));
On 2015/04/23 17:35:39, bbudge wrote:
> You should probably have a base::checked_cast to narrow size_t to uint32_t
here
> and other call sites for MakeArrayBufferPPVar.

Done.

https://codereview.chromium.org/1072403009/diff/80001/content/renderer/pepper...
content/renderer/pepper/content_decryptor_delegate.cc:1220: static_cast<const
uint8_t*>(NULL));
On 2015/04/23 17:35:39, bbudge wrote:
> As long as you're here, s/NULL/nullptr. Then you can eliminate the cast.

Done.

[bbudge, 2015-04-23 22:00:15]

LGTM

[gunsch, 2015-04-23 22:50:45]

lgtm

[jrummell, 2015-04-24 00:45:12]

The CQ bit was checked by jrummell@chromium.org

[jrummell, 2015-04-24 00:45:12]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/1072403009/#ps100001
(title: "checked_cast")

[commit-bot: I haz the power, 2015-04-24 00:45:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1072403009/100001

[commit-bot: I haz the power, 2015-04-24 00:53:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-24 00:53:36]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[jrummell, 2015-04-24 17:09:44]

The CQ bit was checked by jrummell@chromium.org

[commit-bot: I haz the power, 2015-04-24 17:10:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1072403009/100001

[commit-bot: I haz the power, 2015-04-24 17:15:51]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-04-24 17:16:50]

Patchset 6 (id:??) landed as
https://crrev.com/f52b16ac4740888ce847620da41357824286a719
Cr-Commit-Position: refs/heads/master@{#326824}