Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 1072403008: Add UseCounters for CSS-related *List interfaces with item() methods (Closed)

Created:
5 years, 8 months ago by philipj_slow
Modified:
5 years, 8 months ago
CC:
blink-reviews, kenneth.christiansen, Yoav Weiss, arv+blink, blink-reviews-style_chromium.org, vivekg_samsung, blink-reviews-css, ed+blinkwatch_opera.com, vivekg, dglazkov+blink, apavlov+blink_chromium.org, Inactive, darktears, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add UseCounters for CSS-related *List interfaces with item() methods By request from Simon Pieters (CSSOM editor) measure the usage of the item() method on the three interfaces that are currently marked as [ArrayClass]. This is to determine the feasibility of removing the usage of [ArrayClass] by using "real" arrays instead. That won't be possible in the case of MediaList, because that interface has other members, but measure it anyway in case some option emerges where removing MediaList.item() would in some way help. Also add a UseCounter for StyleSheetList's anonymous named getter, which is the only other thing blocking array conversion of that interface. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194040

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M Source/core/css/CSSRuleList.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/MediaList.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StyleSheetList.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/css/StyleSheetList.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
philipj_slow
PTAL
5 years, 8 months ago (2015-04-20 14:58:00 UTC) #2
Erik Dahlström (inactive)
Not an owner, but LGTM. Consider if it's worth adding a testcase to check that ...
5 years, 8 months ago (2015-04-20 15:13:12 UTC) #3
philipj_slow
On 2015/04/20 15:13:12, Erik Dahlström wrote: > Not an owner, but LGTM. > > Consider ...
5 years, 8 months ago (2015-04-20 15:20:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072403008/1
5 years, 8 months ago (2015-04-20 15:21:27 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 17:39:40 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194040

Powered by Google App Engine
This is Rietveld 408576698