Add ApiCompatibilityUtilsTest#testFinishAndRemoveTask

Add ApiCompatibilityUtilsTest#testFinishAndRemoveTask

BUG=434572
Committed: https://crrev.com/23709e96cb063e5084776d4990e531c3df2e9250
Cr-Commit-Position: refs/heads/master@{#325344}

[Jaekyun Seok (inactive), 2015-04-15 04:17:09]

jaekyun@chromium.org changed reviewers:
+ aurimas@chromium.org, nyquist@chromium.org

[Jaekyun Seok (inactive), 2015-04-15 04:17:10]

nyquist@c and aurimas@, please review this CL.

[nyquist, 2015-04-15 22:26:20]

lgtm

https://codereview.chromium.org/1072403004/diff/20001/base/android/javatests/...
File base/android/javatests/src/org/chromium/base/ApiCompatibilityUtilsTest.java
(right):

https://codereview.chromium.org/1072403004/diff/20001/base/android/javatests/...
base/android/javatests/src/org/chromium/base/ApiCompatibilityUtilsTest.java:59:
assertEquals(3, activity.mFinishAndRemoveTaskCallbackCount);
Nit: Could you add a comment here that says something about
MockActivity#finishAndRemoveTask() never sets isFinishing() to true for
LOLLIPOP?

I know this test is short and concise, but it tripped me up the first time I
read this code.

[Jaekyun Seok (inactive), 2015-04-15 23:13:37]

https://codereview.chromium.org/1072403004/diff/20001/base/android/javatests/...
File base/android/javatests/src/org/chromium/base/ApiCompatibilityUtilsTest.java
(right):

https://codereview.chromium.org/1072403004/diff/20001/base/android/javatests/...
base/android/javatests/src/org/chromium/base/ApiCompatibilityUtilsTest.java:59:
assertEquals(3, activity.mFinishAndRemoveTaskCallbackCount);
On 2015/04/15 22:26:20, nyquist wrote:
> Nit: Could you add a comment here that says something about
> MockActivity#finishAndRemoveTask() never sets isFinishing() to true for
> LOLLIPOP?
> 
> I know this test is short and concise, but it tripped me up the first time I
> read this code.

Done.

[Jaekyun Seok (inactive), 2015-04-15 23:13:58]

The CQ bit was checked by jaekyun@chromium.org

[Jaekyun Seok (inactive), 2015-04-15 23:13:59]

The patchset sent to the CQ was uploaded after l-g-t-m from nyquist@chromium.org
Link to the patchset: https://codereview.chromium.org/1072403004/#ps40001
(title: "Add comments")

[commit-bot: I haz the power, 2015-04-15 23:14:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1072403004/40001

[commit-bot: I haz the power, 2015-04-15 23:38:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-15 23:39:23]

Patchset 3 (id:??) landed as
https://crrev.com/23709e96cb063e5084776d4990e531c3df2e9250
Cr-Commit-Position: refs/heads/master@{#325344}