ui/ozone/platform/drm/gpu/screen_manager.cc - Issue 1072383003: ozone: drm: Fix HardwareDisplayController use-after-free

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/ozone/platform/drm/gpu/screen_manager.cc

Issue 1072383003: ozone: drm: Fix HardwareDisplayController use-after-free (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add test Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/ozone/platform/drm/gpu/screen_manager.cc

diff --git a/ui/ozone/platform/drm/gpu/screen_manager.cc b/ui/ozone/platform/drm/gpu/screen_manager.cc

index b8b1fd3747952ce505d3de2dfeb99c54048bcc29..5793572c2beb030efc6a19e6f02196cb20ef509c 100644

--- a/ui/ozone/platform/drm/gpu/screen_manager.cc

+++ b/ui/ozone/platform/drm/gpu/screen_manager.cc

@@ -99,8 +99,8 @@ void ScreenManager::RemoveDisplayController(const scoped_refptr<DrmDevice>& drm,

bool is_mirrored = (*it)->IsMirrored();

(*it)->RemoveCrtc(drm, crtc);

if (!is_mirrored) {

- UpdateControllerToWindowMapping();

controllers_.erase(it);

+ UpdateControllerToWindowMapping();

}

« no previous file with comments | « no previous file | ui/ozone/platform/drm/gpu/screen_manager_unittest.cc » ('j') | no next file with comments »