Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1072363002: Make full GC reduce memory footprint an explicit event in the idle notification handler. (Closed)

Created:
5 years, 8 months ago by Hannes Payer (out of office)
Modified:
5 years, 8 months ago
Reviewers:
ulan, rmcilroy
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make full GC reduce memory footprint an explicit event in the idle notification handler. BUG= Committed: https://crrev.com/845705aa99b6bfa8d264cfda1c3b5f1229802ab5 Cr-Commit-Position: refs/heads/master@{#27753}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -12 lines) Patch
M src/heap/gc-idle-time-handler.h View 4 chunks +15 lines, -0 lines 2 comments Download
M src/heap/gc-idle-time-handler.cc View 1 4 chunks +21 lines, -8 lines 0 comments Download
M src/heap/heap.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M test/unittests/heap/gc-idle-time-handler-unittest.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Hannes Payer (out of office)
5 years, 8 months ago (2015-04-10 09:07:11 UTC) #2
ulan
lgtm
5 years, 8 months ago (2015-04-10 09:21:18 UTC) #3
rmcilroy
lgtm. https://codereview.chromium.org/1072363002/diff/20001/src/heap/gc-idle-time-handler.h File src/heap/gc-idle-time-handler.h (right): https://codereview.chromium.org/1072363002/diff/20001/src/heap/gc-idle-time-handler.h#newcode136 src/heap/gc-idle-time-handler.h:136: static const size_t kMinTimeForReduceMemory = 600; I'm guessing ...
5 years, 8 months ago (2015-04-10 11:14:36 UTC) #4
Hannes Payer (out of office)
https://codereview.chromium.org/1072363002/diff/20001/src/heap/gc-idle-time-handler.h File src/heap/gc-idle-time-handler.h (right): https://codereview.chromium.org/1072363002/diff/20001/src/heap/gc-idle-time-handler.h#newcode136 src/heap/gc-idle-time-handler.h:136: static const size_t kMinTimeForReduceMemory = 600; On 2015/04/10 11:14:35, ...
5 years, 8 months ago (2015-04-10 13:06:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072363002/20001
5 years, 8 months ago (2015-04-10 13:09:55 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-10 14:06:50 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/845705aa99b6bfa8d264cfda1c3b5f1229802ab5 Cr-Commit-Position: refs/heads/master@{#27753}
5 years, 8 months ago (2015-04-10 14:07:06 UTC) #9
Michael Achenbach
5 years, 8 months ago (2015-04-10 18:21:22 UTC) #10
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1081443002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] breaks nosnap with timeouts:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds...
http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20....

Powered by Google App Engine
This is Rietveld 408576698