[turbofan] Optimize silent hole checks on legacy const context slots.

src/compiler/common-operator-reducer.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/common-operator-reducer.h"
 
 #include <algorithm>
 
 #include "src/compiler/common-operator.h"
 #include "src/compiler/js-graph.h"
@@ skipping 91 matching lines @@
   return NoChange();
 }
 
 
 Reduction CommonOperatorReducer::ReduceSelect(Node* node) {
   DCHECK_EQ(IrOpcode::kSelect, node->opcode());
   Node* cond = NodeProperties::GetValueInput(node, 0);
   Node* vtrue = NodeProperties::GetValueInput(node, 1);
   Node* vfalse = NodeProperties::GetValueInput(node, 2);
   if (vtrue == vfalse) return Replace(vtrue);
-  if (cond->opcode() == IrOpcode::kFloat32LessThan) {
-    Float32BinopMatcher mcond(cond);
-    if (mcond.left().Is(0.0) && mcond.right().Equals(vtrue) &&
-        vfalse->opcode() == IrOpcode::kFloat32Sub &&
-        machine()->HasFloat32Abs()) {
-      Float32BinopMatcher mvfalse(vfalse);
-      if (mvfalse.left().IsZero() && mvfalse.right().Equals(vtrue)) {
-        return Change(node, machine()->Float32Abs(), vtrue);
+  switch (cond->opcode()) {
+    case IrOpcode::kHeapConstant: {
+      HeapObjectMatcher<HeapObject> mcond(cond);
+      if (mcond.Is(

[Michael Starzinger, 2015/04/10 09:32:39]

We should be able to use the following here ...

Handle<Object> object = HeapObjectMatcher<HeapObject>(cond).Value().handle();
return Replace(object->BooleanValue() ? vtrue : vfalse);

[Benedikt Meurer, 2015/04/10 09:39:38]

Done.

+              Unique<HeapObject>::CreateImmovable(factory()->true_value()))) {
+        return Replace(vtrue);
       }
+      if (mcond.Is(
+              Unique<HeapObject>::CreateImmovable(factory()->false_value()))) {
+        return Replace(vfalse);
+      }
+      break;
     }
-    if (mcond.left().Equals(vtrue) && mcond.right().Equals(vfalse) &&
-        machine()->HasFloat32Min()) {
-      return Change(node, machine()->Float32Min(), vtrue, vfalse);
-    } else if (mcond.left().Equals(vfalse) && mcond.right().Equals(vtrue) &&
-               machine()->HasFloat32Max()) {
-      return Change(node, machine()->Float32Max(), vtrue, vfalse);
+    case IrOpcode::kFloat32LessThan: {
+      Float32BinopMatcher mcond(cond);
+      if (mcond.left().Is(0.0) && mcond.right().Equals(vtrue) &&
+          vfalse->opcode() == IrOpcode::kFloat32Sub &&
+          machine()->HasFloat32Abs()) {
+        Float32BinopMatcher mvfalse(vfalse);
+        if (mvfalse.left().IsZero() && mvfalse.right().Equals(vtrue)) {
+          return Change(node, machine()->Float32Abs(), vtrue);
+        }
+      }
+      if (mcond.left().Equals(vtrue) && mcond.right().Equals(vfalse) &&
+          machine()->HasFloat32Min()) {
+        return Change(node, machine()->Float32Min(), vtrue, vfalse);
+      } else if (mcond.left().Equals(vfalse) && mcond.right().Equals(vtrue) &&
+                 machine()->HasFloat32Max()) {
+        return Change(node, machine()->Float32Max(), vtrue, vfalse);
+      }
+      break;
     }
-  } else if (cond->opcode() == IrOpcode::kFloat64LessThan) {
-    Float64BinopMatcher mcond(cond);
-    if (mcond.left().Is(0.0) && mcond.right().Equals(vtrue) &&
-        vfalse->opcode() == IrOpcode::kFloat64Sub &&
-        machine()->HasFloat64Abs()) {
-      Float64BinopMatcher mvfalse(vfalse);
-      if (mvfalse.left().IsZero() && mvfalse.right().Equals(vtrue)) {
-        return Change(node, machine()->Float64Abs(), vtrue);
+    case IrOpcode::kFloat64LessThan: {
+      Float64BinopMatcher mcond(cond);
+      if (mcond.left().Is(0.0) && mcond.right().Equals(vtrue) &&
+          vfalse->opcode() == IrOpcode::kFloat64Sub &&
+          machine()->HasFloat64Abs()) {
+        Float64BinopMatcher mvfalse(vfalse);
+        if (mvfalse.left().IsZero() && mvfalse.right().Equals(vtrue)) {
+          return Change(node, machine()->Float64Abs(), vtrue);
+        }
       }
+      if (mcond.left().Equals(vtrue) && mcond.right().Equals(vfalse) &&
+          machine()->HasFloat64Min()) {
+        return Change(node, machine()->Float64Min(), vtrue, vfalse);
+      } else if (mcond.left().Equals(vfalse) && mcond.right().Equals(vtrue) &&
+                 machine()->HasFloat64Max()) {
+        return Change(node, machine()->Float64Max(), vtrue, vfalse);
+      }
+      break;
     }
-    if (mcond.left().Equals(vtrue) && mcond.right().Equals(vfalse) &&
-        machine()->HasFloat64Min()) {
-      return Change(node, machine()->Float64Min(), vtrue, vfalse);
-    } else if (mcond.left().Equals(vfalse) && mcond.right().Equals(vtrue) &&
-               machine()->HasFloat64Max()) {
-      return Change(node, machine()->Float64Max(), vtrue, vfalse);
-    }
+    default:
+      break;
   }
   return NoChange();
 }
 
 
 Reduction CommonOperatorReducer::Change(Node* node, Operator const* op,
                                         Node* a) {
   node->set_op(op);
   node->ReplaceInput(0, a);
   node->TrimInputCount(1);
@@ skipping 12 matching lines @@
 
 
 CommonOperatorBuilder* CommonOperatorReducer::common() const {
   return jsgraph()->common();
 }
 
 
 Graph* CommonOperatorReducer::graph() const { return jsgraph()->graph(); }
 
 
+Factory* CommonOperatorReducer::factory() const {

[Michael Starzinger, 2015/04/10 09:32:39]

If the above suggestion works, then the factory getter here and in the header
file are obsolete.

[Benedikt Meurer, 2015/04/10 09:39:38]

Done.

+  return jsgraph()->isolate()->factory();
+}
+
+
 MachineOperatorBuilder* CommonOperatorReducer::machine() const {
   return jsgraph()->machine();
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8