Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Issue 1072333002: Fix some -Werror=sign-compare errors (Closed)

Created:
5 years, 8 months ago by wingo
Modified:
5 years, 8 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix some -Werror=sign-compare errors R=svenpanne@chromium.org LOG=N BUG= Committed: https://crrev.com/fe031978cbd4fbe589cf6d5e6aca291b611f1adb Cr-Commit-Position: refs/heads/master@{#27752}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M src/utils.h View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 4 chunks +6 lines, -6 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
wingo
Found while compiling with GCC 4.9.2.
5 years, 8 months ago (2015-04-10 08:15:57 UTC) #1
Sven Panne
lgtm https://codereview.chromium.org/1072333002/diff/1/test/cctest/test-cpu-profiler.cc File test/cctest/test-cpu-profiler.cc (right): https://codereview.chromium.org/1072333002/diff/1/test/cctest/test-cpu-profiler.cc#newcode1724 test/cctest/test-cpu-profiler.cc:1724: CHECK_EQ(1U, iopt_function->deopt_infos().size()); To *really* be on the safe ...
5 years, 8 months ago (2015-04-10 13:09:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072333002/1
5 years, 8 months ago (2015-04-10 13:09:40 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-10 13:59:46 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 13:59:55 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe031978cbd4fbe589cf6d5e6aca291b611f1adb
Cr-Commit-Position: refs/heads/master@{#27752}

Powered by Google App Engine
This is Rietveld 408576698