Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 107233005: Revert 164094 "This review merges the two existing page serializ..." (Closed)

Created:
7 years ago by Julien - ping for review
Modified:
7 years ago
Reviewers:
Tiger
CC:
blink-reviews
Visibility:
Public.

Description

Revert 164094 "This review merges the two existing page serializ..." This change is making 2 browser_tests fail: - BrowserEncodingTest.TestOverrideEncoding - BrowserEncodingTest.TestEncodingAutoDetect > This review merges the two existing page serializers, WebPageSerializerImpl and > PageSerializer, into one, PageSerializer. In addition to this it moves all > the old tests from WebPageNewSerializerTest and WebPageSerializerTest to the > PageSerializerTest structure and splits out one test for MHTML into a new > MHTMLTest file. > > Saving as 'Webpage, Complete', 'Webpage, HTML Only' and as MHTML when the > 'Save Page as MHTML' flag is enabled now uses the same code, and should thus > have the same feature set. Meaning that both modes now should be a bit better. > > Detailed list of changes: > > - PageSerializerTest: Prepare for more DTD test > - PageSerializerTest: Remove now unneccesary input image test > - PageSerializerTest: Remove unused WebPageSerializer/Impl code > - PageSerializerTest: Move data URI morph test > - PageSerializerTest: Move data URI test > - PageSerializerTest: Move namespace test > - PageSerializerTest: Move SVG Image test > - MHTMLTest: Move MHTML specific test to own test file > - PageSerializerTest: Delete duplicate XML header test > - PageSerializerTest: Move blank frame test > - PageSerializerTest: Move CSS test > - PageSerializerTest: Add frameset/frame test > - PageSerializerTest: Move old iframe test > - PageSerializerTest: Move old elements test > - Use PageSerizer for saving web pages > - PageSerializerTest: Test for rewriting links > - PageSerializer: Add rewrite link accumulator > - PageSerializer: Serialize images in iframes/frames src > - PageSerializer: XHTML fix for meta tags > - PageSerializer: Add presentation CSS > - PageSerializer: Rename out parameter > > BUG=328354 > R=abarth@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162155 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162294 > > Review URL: https://codereview.chromium.org/68613003 TBR=tiger@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164119

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -926 lines) Patch
M trunk/Source/core/dom/Element.h View 2 chunks +2 lines, -1 line 0 comments Download
M trunk/Source/core/editing/MarkupAccumulator.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/page/PageSerializer.h View 2 chunks +1 line, -7 lines 0 comments Download
M trunk/Source/core/page/PageSerializer.cpp View 8 chunks +24 lines, -119 lines 0 comments Download
M trunk/Source/web/WebPageSerializer.cpp View 3 chunks +160 lines, -15 lines 0 comments Download
A + trunk/Source/web/WebPageSerializerImpl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/web/WebPageSerializerImpl.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/Source/web/tests/MHTMLTest.cpp View 1 chunk +0 lines, -169 lines 0 comments Download
M trunk/Source/web/tests/PageSerializerTest.cpp View 7 chunks +14 lines, -279 lines 0 comments Download
M trunk/Source/web/tests/WebFrameTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + trunk/Source/web/tests/WebPageNewSerializerTest.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/web/tests/WebPageSerializerTest.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserialization/awesome.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserialization/beautifull.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserialization/embed_iframe.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserialization/object_iframe.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserialization/simple_iframe.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserialization/simple_page.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserialization/top_frame.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserializer/blank_frames.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserializer/blue_background.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/Source/web/tests/data/pageserializer/css/css_test_page.html View 1 chunk +0 lines, -108 lines 0 comments Download
D trunk/Source/web/tests/data/pageserializer/css/image.png View Binary file 0 comments Download
D trunk/Source/web/tests/data/pageserializer/css/import_style_from_link.css View 1 chunk +0 lines, -3 lines 0 comments Download
D trunk/Source/web/tests/data/pageserializer/css/import_styles.css View 1 chunk +0 lines, -3 lines 0 comments Download
D trunk/Source/web/tests/data/pageserializer/css/link_styles.css View 1 chunk +0 lines, -5 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserializer/css_test_page.html View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/Source/web/tests/data/pageserializer/datauri/page_with_data.html View 1 chunk +0 lines, -10 lines 0 comments Download
D trunk/Source/web/tests/data/pageserializer/datauri/page_with_morphing_data.html View 1 chunk +0 lines, -9 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserializer/dtd/dtd.html View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/Source/web/tests/data/pageserializer/dtd/html5.html View 1 chunk +0 lines, -10 lines 0 comments Download
D trunk/Source/web/tests/data/pageserializer/elements/elements.html View 1 chunk +0 lines, -45 lines 0 comments Download
D trunk/Source/web/tests/data/pageserializer/elements/image.png View Binary file 0 comments Download
D trunk/Source/web/tests/data/pageserializer/elements/style.css View 1 chunk +0 lines, -3 lines 0 comments Download
D trunk/Source/web/tests/data/pageserializer/elements/text.txt View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/Source/web/tests/data/pageserializer/frames/blank_frames.html View 1 chunk +0 lines, -36 lines 0 comments Download
D trunk/Source/web/tests/data/pageserializer/frames/embed_iframe.html View 1 chunk +0 lines, -3 lines 0 comments Download
D trunk/Source/web/tests/data/pageserializer/frames/image.png View Binary file 0 comments Download
D trunk/Source/web/tests/data/pageserializer/frames/object_iframe.html View 1 chunk +0 lines, -3 lines 0 comments Download
D trunk/Source/web/tests/data/pageserializer/frames/simple_frames.html View 1 chunk +0 lines, -14 lines 0 comments Download
D trunk/Source/web/tests/data/pageserializer/frames/simple_frames_1.html View 1 chunk +0 lines, -3 lines 0 comments Download
D trunk/Source/web/tests/data/pageserializer/frames/simple_frames_3.html View 1 chunk +0 lines, -3 lines 0 comments Download
D trunk/Source/web/tests/data/pageserializer/frames/simple_frames_top.html View 1 chunk +0 lines, -7 lines 0 comments Download
D trunk/Source/web/tests/data/pageserializer/frames/simple_iframe.html View 1 chunk +0 lines, -5 lines 0 comments Download
D trunk/Source/web/tests/data/pageserializer/frames/top_frame.html View 1 chunk +0 lines, -21 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserializer/green_background.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserializer/green_rectangle.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserializer/iframe.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserializer/iframe2.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserializer/import_style_from_link.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserializer/import_styles.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserializer/input-image/button.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserializer/input-image/input-image.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserializer/link_styles.css View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/Source/web/tests/data/pageserializer/namespace/namespace_element.html View 1 chunk +0 lines, -14 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserializer/namespace_element.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserializer/ol-dot.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserializer/orange_background.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserializer/page_with_data.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserializer/page_with_morphing_data.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserializer/page_with_svg_image.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserializer/purple_background.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserializer/red_background.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/Source/web/tests/data/pageserializer/rewritelinks/image.png View Binary file 0 comments Download
D trunk/Source/web/tests/data/pageserializer/rewritelinks/rewritelinks_base.html View 1 chunk +0 lines, -13 lines 0 comments Download
D trunk/Source/web/tests/data/pageserializer/rewritelinks/rewritelinks_simple.html View 1 chunk +0 lines, -9 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserializer/simple.xhtml View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/Source/web/tests/data/pageserializer/svg/green_rectangle.svg View 1 chunk +0 lines, -11 lines 0 comments Download
D trunk/Source/web/tests/data/pageserializer/svg/page_with_svg_image.html View 1 chunk +0 lines, -9 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserializer/top_frame.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserializer/ul-dot.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/Source/web/tests/data/pageserializer/xml/simple.xhtml View 1 chunk +0 lines, -10 lines 0 comments Download
D trunk/Source/web/tests/data/pageserializer/xml/xmldecl.xml View 1 chunk +0 lines, -5 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserializer/xmldecl/xmldecl.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/Source/web/tests/data/pageserializer/yellow_background.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/Source/web/web.gypi View 4 chunks +6 lines, -1 line 0 comments Download
MM trunk/public/web/WebPageSerializer.h View 1 chunk +13 lines, -5 lines 0 comments Download
MM trunk/public/web/WebPageSerializerClient.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Julien - ping for review
7 years ago (2013-12-18 21:50:14 UTC) #1
Julien - ping for review
Committed patchset #1 manually as r164119.
7 years ago (2013-12-18 21:50:44 UTC) #2
Julien - ping for review
7 years ago (2013-12-18 21:52:02 UTC) #3
Message was sent while issue was closed.
Failure run:
http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%2...

The PPAPIPPPInstance failure was unrelated to a Chromium change.

Powered by Google App Engine
This is Rietveld 408576698