Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1072273008: Keep result of IMMEDIATE_CRASH void after r194230. (Closed)

Created:
5 years, 8 months ago by Nico
Modified:
5 years, 8 months ago
Reviewers:
hiroshige, haraken
CC:
blink-reviews, blink-reviews-wtf_chromium.org, aandrey+blink_chromium.org, Mikhail, Chris Evans, Will Harris, hans
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Keep result of IMMEDIATE_CRASH void after r194230. Fixes compile errors like ..\..\third_party\WebKit\Source\wtf/text/StringConcatenate.h(168,9) : error: right operand to ? is void, but left operand is of type 'volatile char' RELEASE_ASSERT(false); ^~~~~~~~~~~~~~~~~~~~~ on systems where __builtin_trap isn't available. BUG=82385 TBR=hiroshige Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194256

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/wtf/Assertions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
5 years, 8 months ago (2015-04-23 01:17:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072273008/1
5 years, 8 months ago (2015-04-23 01:17:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=194256
5 years, 8 months ago (2015-04-23 02:57:36 UTC) #5
haraken
LGTM
5 years, 8 months ago (2015-04-23 04:19:55 UTC) #6
hiroshige
5 years, 8 months ago (2015-04-23 05:18:06 UTC) #7
Message was sent while issue was closed.
lgtm.

Powered by Google App Engine
This is Rietveld 408576698