Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: Source/modules/accessibility/AXSpinButton.cpp

Issue 1072273006: Oilpan: Prepare moving AXObject to heap (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/accessibility/AXSpinButton.h ('k') | Source/modules/accessibility/AXTable.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXSpinButton.cpp
diff --git a/Source/modules/accessibility/AXSpinButton.cpp b/Source/modules/accessibility/AXSpinButton.cpp
index ed9e3b339b2902ad56c61f99a009c03c91e38bb3..e97dc8e14b63103827f7aa355f758eafaa9695bc 100644
--- a/Source/modules/accessibility/AXSpinButton.cpp
+++ b/Source/modules/accessibility/AXSpinButton.cpp
@@ -31,19 +31,26 @@
namespace blink {
-PassRefPtr<AXSpinButton> AXSpinButton::create(AXObjectCacheImpl& axObjectCache)
+PassRefPtrWillBeRawPtr<AXSpinButton> AXSpinButton::create(AXObjectCacheImpl& axObjectCache)
{
- return adoptRef(new AXSpinButton(axObjectCache));
+ return adoptRefWillBeNoop(new AXSpinButton(axObjectCache));
}
AXSpinButton::AXSpinButton(AXObjectCacheImpl& axObjectCache)
: AXMockObject(axObjectCache)
- , m_spinButtonElement(0)
+ , m_spinButtonElement(nullptr)
{
}
AXSpinButton::~AXSpinButton()
{
+ ASSERT(!m_spinButtonElement);
+}
+
+DEFINE_TRACE(AXSpinButton)
+{
+ visitor->trace(m_spinButtonElement);
+ AXMockObject::trace(visitor);
}
LayoutRect AXSpinButton::elementRect() const
@@ -57,13 +64,13 @@ LayoutRect AXSpinButton::elementRect() const
void AXSpinButton::detach()
{
AXObject::detach();
- m_spinButtonElement = 0;
+ m_spinButtonElement = nullptr;
}
void AXSpinButton::detachFromParent()
{
AXObject::detachFromParent();
- m_spinButtonElement = 0;
+ m_spinButtonElement = nullptr;
}
AccessibilityRole AXSpinButton::roleValue() const
@@ -103,9 +110,9 @@ AXSpinButtonPart::AXSpinButtonPart(AXObjectCacheImpl& axObjectCache)
{
}
-PassRefPtr<AXSpinButtonPart> AXSpinButtonPart::create(AXObjectCacheImpl& axObjectCache)
+PassRefPtrWillBeRawPtr<AXSpinButtonPart> AXSpinButtonPart::create(AXObjectCacheImpl& axObjectCache)
{
- return adoptRef(new AXSpinButtonPart(axObjectCache));
+ return adoptRefWillBeNoop(new AXSpinButtonPart(axObjectCache));
}
LayoutRect AXSpinButtonPart::elementRect() const
« no previous file with comments | « Source/modules/accessibility/AXSpinButton.h ('k') | Source/modules/accessibility/AXTable.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698