Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2112)

Unified Diff: Source/modules/accessibility/AXMenuListOption.h

Issue 1072273006: Oilpan: Prepare moving AXObject to heap (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/accessibility/AXMenuList.cpp ('k') | Source/modules/accessibility/AXMenuListOption.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXMenuListOption.h
diff --git a/Source/modules/accessibility/AXMenuListOption.h b/Source/modules/accessibility/AXMenuListOption.h
index 92cf32d8bb7ff27863b3931e3aacef52fb4c182a..eee7a20a4eba417ad324353301670f015fb741ac 100644
--- a/Source/modules/accessibility/AXMenuListOption.h
+++ b/Source/modules/accessibility/AXMenuListOption.h
@@ -35,10 +35,12 @@ class AXObjectCacheImpl;
class AXMenuListOption final : public AXMockObject {
public:
- static PassRefPtr<AXMenuListOption> create(HTMLOptionElement* element, AXObjectCacheImpl& axObjectCache) { return adoptRef(new AXMenuListOption(element, axObjectCache)); }
+ static PassRefPtrWillBeRawPtr<AXMenuListOption> create(HTMLOptionElement* element, AXObjectCacheImpl& axObjectCache) { return adoptRefWillBeNoop(new AXMenuListOption(element, axObjectCache)); }
+ virtual ~AXMenuListOption();
private:
- explicit AXMenuListOption(HTMLOptionElement*, AXObjectCacheImpl&);
+ AXMenuListOption(HTMLOptionElement*, AXObjectCacheImpl&);
+ DECLARE_VIRTUAL_TRACE();
virtual bool isMenuListOption() const override { return true; }
@@ -59,7 +61,7 @@ private:
virtual String stringValue() const override;
virtual bool computeAccessibilityIsIgnored(IgnoredReasons* = nullptr) const override;
- HTMLOptionElement* m_element;
+ RawPtrWillBeMember<HTMLOptionElement> m_element;
};
DEFINE_AX_OBJECT_TYPE_CASTS(AXMenuListOption, isMenuListOption());
« no previous file with comments | « Source/modules/accessibility/AXMenuList.cpp ('k') | Source/modules/accessibility/AXMenuListOption.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698